On Thu, Feb 14, 2013 at 06:39:36PM -0600, Kim Phillips wrote: > On Thu, 14 Feb 2013 10:32:56 +1100 > David Gibson wrote: > > > On Wed, Feb 13, 2013 at 11:32:01AM -0500, Justin Sobota wrote: > > > This commit adds a license header to fdt.h and libfdt_env.h because > > > the license was omitted > > > > So, having a quick look at the git blame for both these files, it > > looks like Kim Phillips (CCed) also touched them substantially. > > > > Kim, did you want to supply an additional copyright line for these files? > > sure, it'd be: > > Copyright 2012 Kim Phillips, Freescale Semiconductor. > > I can spin a patch on top of this one, or - wait... > > > > Signed-off-by: Justin Sobota > > > --- > > > libfdt/fdt.h | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++ > > > libfdt/libfdt_env.h | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++ > > > 2 files changed, 100 insertions(+) > > > mode change 100644 => 100755 libfdt/fdt.h > > > mode change 100644 => 100755 libfdt/libfdt_env.h > > ...what's up with making them executable? Good point, didn't notice that. I'm guessing an accidental transition through a FAT filing system. > So I'm assuming this patch is going to be respun to not include the > mode changes, in which case please add the above copyright line > under David's. > > Thanks, > > Kim > -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson