Re: [PATCH 1/7] staging/ozwpan: Fix sparse warning Using plain integer as NULL pointer

From: Dan Carpenter <dan.carpenter@oracle.com>
To: Peter Huewe <peterhuewe@gmx.de>
Cc: Rupesh Gujare <rupesh.gujare@atmel.com>,
	devel@driverdev.osuosl.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] staging/ozwpan: Fix sparse warning Using plain integer as NULL pointer
Date: Fri, 15 Feb 2013 11:45:17 +0300	[thread overview]
Message-ID: <20130215084517.GB6802@mwanda> (raw)
In-Reply-To: <1360905935-20601-1-git-send-email-peterhuewe@gmx.de>

On Fri, Feb 15, 2013 at 06:25:29AM +0100, Peter Huewe wrote:
> This patch fixes the warning "Using plain integer as NULL pointer",
> generated by sparse, by replacing the offending 0s with NULL.
> 
> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>

Don't send 7 patches with the same subject.

> @@ -455,7 +455,7 @@ int oz_prepare_frame(struct oz_pd *pd, int empty)
>   */
>  static struct sk_buff *oz_build_frame(struct oz_pd *pd, struct oz_tx_frame *f)
>  {
> -	struct sk_buff *skb = 0;
> +	struct sk_buff *skb = NULL;

This initialization could just be removed.

>  	struct net_device *dev = pd->net_dev;
>  	struct oz_hdr *oz_hdr;
>  	struct oz_elt *elt;
> @@ -464,8 +464,8 @@ static struct sk_buff *oz_build_frame(struct oz_pd *pd, struct oz_tx_frame *f)
>  	 * as the space we need.
>  	 */
>  	skb = alloc_skb(f->total_size + OZ_ALLOCATED_SPACE(dev), GFP_ATOMIC);
> -	if (skb == 0)
> -		return 0;
> +	if (skb == NULL)
> +		return NULL;

regards,
dan carpenter