From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 3/3] drm/i915: Update primary planes after a GPU reset Date: Fri, 15 Feb 2013 15:28:33 +0000 Message-ID: <20130215152833.GB4208@cantiga.alporthouse.com> References: <1360940866-22435-1-git-send-email-ville.syrjala@linux.intel.com> <1360940866-22435-4-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 5C281E5C14 for ; Fri, 15 Feb 2013 07:28:41 -0800 (PST) Content-Disposition: inline In-Reply-To: <1360940866-22435-4-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Feb 15, 2013 at 05:07:46PM +0200, ville.syrjala@linux.intel.com wro= te: > From: Ville Syrj=E4l=E4 > = > GPU reset will drop all flips that are still in the ring. So after the > reset, call update_plane() for all CRTCs to make sure the primary > planes are scanning out from the correct buffer. > = > The base address update will also generate a FLIP_DONE interrupt, which > will complete any pending flips. That means user space will get its > page flip events and won't get stuck waiting for them. Not for all generations. There's no harm in explicitly finishing the pageflip, and then the FLIP_DONE is just a normal spurious interrupt. -Chris -- = Chris Wilson, Intel Open Source Technology Centre