From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751610Ab3BOThm (ORCPT ); Fri, 15 Feb 2013 14:37:42 -0500 Received: from sauhun.de ([89.238.76.85]:34071 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751035Ab3BOThl (ORCPT ); Fri, 15 Feb 2013 14:37:41 -0500 Date: Fri, 15 Feb 2013 20:37:36 +0100 From: Wolfram Sang To: Doug Anderson Cc: Stephen Warren , Peter Korsgaard , "Ben Dooks (embedded platforms)" , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] i2c: mux: Remove unneeded platform_set_drvdata to NULL in remove Message-ID: <20130215193736.GD4351@the-dreams.de> References: <1360953682-25066-1-git-send-email-dianders@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1360953682-25066-1-git-send-email-dianders@chromium.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 15, 2013 at 10:41:22AM -0800, Doug Anderson wrote: > Stephen Warren pointed out as part of a code review of another mux > driver that there should be no need to have > "platform_set_drvdata(pdev, NULL)" in the remove function. Get rid of > it in the i2c-mux-gpio driver. > > See Stephen's comment at: > http://www.gossamer-threads.com/lists/linux/kernel/1678627?do=post_view_threaded#1678627 > > Signed-off-by: Doug Anderson I think we should do this at least I2C subsystem wide (51 occasions of setting some *_drvdata to NULL), even better kernel-wide. Patching individual drivers won't cut the confusion around this issue, I am afraid. Thanks, Wolfram From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: [PATCH] i2c: mux: Remove unneeded platform_set_drvdata to NULL in remove Date: Fri, 15 Feb 2013 20:37:36 +0100 Message-ID: <20130215193736.GD4351@the-dreams.de> References: <1360953682-25066-1-git-send-email-dianders@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1360953682-25066-1-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Doug Anderson Cc: Stephen Warren , Peter Korsgaard , "Ben Dooks (embedded platforms)" , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-i2c@vger.kernel.org On Fri, Feb 15, 2013 at 10:41:22AM -0800, Doug Anderson wrote: > Stephen Warren pointed out as part of a code review of another mux > driver that there should be no need to have > "platform_set_drvdata(pdev, NULL)" in the remove function. Get rid of > it in the i2c-mux-gpio driver. > > See Stephen's comment at: > http://www.gossamer-threads.com/lists/linux/kernel/1678627?do=post_view_threaded#1678627 > > Signed-off-by: Doug Anderson I think we should do this at least I2C subsystem wide (51 occasions of setting some *_drvdata to NULL), even better kernel-wide. Patching individual drivers won't cut the confusion around this issue, I am afraid. Thanks, Wolfram