All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Doug Anderson <dianders@chromium.org>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
	Peter Korsgaard <peter.korsgaard@barco.com>,
	"Ben Dooks (embedded platforms)" <ben-linux@fluff.org>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i2c: mux: Remove unneeded platform_set_drvdata to NULL in remove
Date: Fri, 15 Feb 2013 20:53:48 +0100	[thread overview]
Message-ID: <20130215195347.GF4351@the-dreams.de> (raw)
In-Reply-To: <CAD=FV=VTJN3bU1rpMyjDMvX1SYZJWoJCiNtHNe+nDrtwnXqTXA@mail.gmail.com>


> I'll re-send with I2C subsystem wide.  I probably won't attempt the
> whole kernel wide at this point, but would be very happy if someone
> else wanted to!  :)

Thanks. Please double check that setting NULL is really unneeded for the
non-platform-bus variants, too, or skip those if you are unsure. Please
also update the commit message to reference a stronger indication than
Stephen's "should not be necessary" ;) I do agree but for the commit
history, a better reference would be nice to educate readers.

Thanks,

   Wolfram


  reply	other threads:[~2013-02-15 19:53 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-15 18:41 [PATCH] i2c: mux: Remove unneeded platform_set_drvdata to NULL in remove Doug Anderson
2013-02-15 19:37 ` Wolfram Sang
2013-02-15 19:37   ` Wolfram Sang
2013-02-15 19:43   ` Doug Anderson
2013-02-15 19:43     ` Doug Anderson
2013-02-15 19:53     ` Wolfram Sang [this message]
2013-02-15 23:17       ` Doug Anderson
2013-02-15 23:17         ` Doug Anderson
2013-02-15 23:18 ` [PATCH] i2c: Remove unneeded xxx_set_drvdata(..., NULL) calls Doug Anderson
2013-02-15 23:18   ` Doug Anderson
2013-02-15 23:18   ` Doug Anderson
2013-02-17 15:12   ` Peter Korsgaard
2013-02-17 15:12     ` Peter Korsgaard
2013-02-17 15:12     ` Peter Korsgaard
2013-02-18 10:35   ` Mika Westerberg
2013-02-18 10:35     ` Mika Westerberg
2013-02-18 12:17   ` Marek Vasut
2013-02-18 12:17     ` Marek Vasut
2013-02-18 12:17     ` Marek Vasut
     [not found]   ` <1360970315-32116-1-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2013-02-16 19:52     ` Jean Delvare
2013-02-16 19:52       ` Jean Delvare
2013-02-16 19:52       ` Jean Delvare
2013-02-21 10:48     ` Wolfram Sang
2013-02-21 10:48       ` Wolfram Sang
2013-02-21 10:48       ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130215195347.GF4351@the-dreams.de \
    --to=wsa@the-dreams.de \
    --cc=ben-linux@fluff.org \
    --cc=dianders@chromium.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.korsgaard@barco.com \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.