From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Implement pipe CSC based limited range RGB output Date: Fri, 15 Feb 2013 21:34:31 +0100 Message-ID: <20130215203431.GG5813@phenom.ffwll.local> References: <1358529098-31596-1-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ee0-f47.google.com (mail-ee0-f47.google.com [74.125.83.47]) by gabe.freedesktop.org (Postfix) with ESMTP id 464F3E5FC3 for ; Fri, 15 Feb 2013 12:32:14 -0800 (PST) Received: by mail-ee0-f47.google.com with SMTP id e52so1871085eek.6 for ; Fri, 15 Feb 2013 12:32:13 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Feb 14, 2013 at 05:30:12PM -0200, Paulo Zanoni wrote: > Hi > = > 2013/1/18 : > > From: Ville Syrj=E4l=E4 > > > > HSW no longer has the PIPECONF bit for limited range RGB output. > > Instead the pipe CSC unit must be used to perform that task. > > > > The CSC pre offset are set to 0, since the incoming data is full > > [0:255] range RGB, the coefficients are programmed to compress the > > data into [0:219] range, and then we use either the CSC_MODE black > > screen offset bit, or the CSC post offsets to shift the data to > > the correct [16:235] range. > > > > Also have to change the confiuration of all planes so that the > > data is sent through the pipe CSC unit. For simplicity send the > > plane data through the pipe CSC unit always, and in case full > > range output is requested, the pipe CSC unit is set up with an > > identity transform to pass the plane data through unchanged. > > > > I've been told by some hardware people that the use of the pipe > > CSC unit shouldn't result in any measurable increase in power > > consumption numbers. > > > > Signed-off-by: Ville Syrj=E4l=E4 > = > Reviewed-by: Paulo Zanoni Queued for -next, thanks for the patch. -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch