From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Date: Sun, 17 Feb 2013 07:52:16 +0000 Subject: Re: [PATCH v5 03/13] mmc: provide a standard MMC device-tree binding parser centrally Message-Id: <20130217075216.GA3871@verge.net.au> List-Id: References: <1360941242-18153-1-git-send-email-g.liakhovetski@gmx.de> <1360941242-18153-4-git-send-email-g.liakhovetski@gmx.de> <20130216165825.GF1906@pengutronix.de> In-Reply-To: <20130216165825.GF1906@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sascha Hauer Cc: Guennadi Liakhovetski , linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, Magnus Damm , Markus Pargmann On Sat, Feb 16, 2013 at 05:58:25PM +0100, Sascha Hauer wrote: > Hi Guennadi, > > On Sat, Feb 16, 2013 at 04:21:16PM +0100, Guennadi Liakhovetski wrote: > > MMC defines a number of standard DT bindings. Having each driver parse > > them individually adds code redundancy and is error prone. Provide a > > standard function to unify the parsing. After all drivers are converted > > to using it instead of their own parsers, this function can be integrated > > into mmc_alloc_host(). > > > > Signed-off-by: Guennadi Liakhovetski > > --- > > > > v5: > > > > 1. fix an uninitialised variable warning. Note, I don't actually know, > > whether this will fix the error, reported by the kbuild test robot. None > > of my compilers reports an error there, at most, I've got a warning with > > one of them, and, surprisingly, it is gone after this change. > > Surprisingly, because I only add the bus_width initialisation in the error > > case - exactly as it actually has to be done. In the success case it is > > assigned set by the function. But the compiler cannot know that! > > Maybe the build robot builds with devicetree disabled? In this case > of_property_read_u32_array expands to a static inline function and the > compiler indeed knows that &bus_width is unitialized. It also knows that > this function always returns an error, so what you did below should > silence the compiler. It seems so. The configuration that flagged the error was atngw100_defconfig. ARCH=avr32 make atngw100_defconfig grep USE_OF .config [nothing] From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Subject: Re: [PATCH v5 03/13] mmc: provide a standard MMC device-tree binding parser centrally Date: Sun, 17 Feb 2013 16:52:16 +0900 Message-ID: <20130217075216.GA3871@verge.net.au> References: <1360941242-18153-1-git-send-email-g.liakhovetski@gmx.de> <1360941242-18153-4-git-send-email-g.liakhovetski@gmx.de> <20130216165825.GF1906@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20130216165825.GF1906@pengutronix.de> Sender: linux-sh-owner@vger.kernel.org To: Sascha Hauer Cc: Guennadi Liakhovetski , linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, Magnus Damm , Markus Pargmann List-Id: devicetree@vger.kernel.org On Sat, Feb 16, 2013 at 05:58:25PM +0100, Sascha Hauer wrote: > Hi Guennadi, > > On Sat, Feb 16, 2013 at 04:21:16PM +0100, Guennadi Liakhovetski wrote: > > MMC defines a number of standard DT bindings. Having each driver parse > > them individually adds code redundancy and is error prone. Provide a > > standard function to unify the parsing. After all drivers are converted > > to using it instead of their own parsers, this function can be integrated > > into mmc_alloc_host(). > > > > Signed-off-by: Guennadi Liakhovetski > > --- > > > > v5: > > > > 1. fix an uninitialised variable warning. Note, I don't actually know, > > whether this will fix the error, reported by the kbuild test robot. None > > of my compilers reports an error there, at most, I've got a warning with > > one of them, and, surprisingly, it is gone after this change. > > Surprisingly, because I only add the bus_width initialisation in the error > > case - exactly as it actually has to be done. In the success case it is > > assigned set by the function. But the compiler cannot know that! > > Maybe the build robot builds with devicetree disabled? In this case > of_property_read_u32_array expands to a static inline function and the > compiler indeed knows that &bus_width is unitialized. It also knows that > this function always returns an error, so what you did below should > silence the compiler. It seems so. The configuration that flagged the error was atngw100_defconfig. ARCH=avr32 make atngw100_defconfig grep USE_OF .config [nothing]