All of lore.kernel.org
 help / color / mirror / Atom feed
From: Karel Zak <kzak@redhat.com>
To: "Zeeshan Ali (Khattak)" <zeeshanak@gnome.org>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH] libblkid: Make use of isalnum()
Date: Mon, 18 Feb 2013 12:23:41 +0100	[thread overview]
Message-ID: <20130218112341.GD11636@x2.net.home> (raw)
In-Reply-To: <1361065052-18695-1-git-send-email-zeeshanak@gnome.org>

On Sun, Feb 17, 2013 at 03:37:32AM +0200, Zeeshan Ali (Khattak) wrote:
> From: "Zeeshan Ali (Khattak)" <zeeshanak@gnome.org>
> 
> ---
>  libblkid/src/encode.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/libblkid/src/encode.c b/libblkid/src/encode.c
> index ff57be4..e96e0e2 100644
> --- a/libblkid/src/encode.c
> +++ b/libblkid/src/encode.c
> @@ -181,9 +181,7 @@ static int replace_whitespace(const char *str, char *to, size_t len)
>  
>  static int is_whitelisted(char c, const char *white)
>  {
> -	if ((c >= '0' && c <= '9') ||
> -	    (c >= 'A' && c <= 'Z') ||
> -	    (c >= 'a' && c <= 'z') ||
> +	if (isalnum (c) ||

 It seems like locale sensitive function ;-)

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

  reply	other threads:[~2013-02-18 11:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-17  1:37 [PATCH] libblkid: Make use of isalnum() Zeeshan Ali (Khattak)
2013-02-18 11:23 ` Karel Zak [this message]
2013-02-18 13:35   ` Zeeshan Ali (Khattak)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130218112341.GD11636@x2.net.home \
    --to=kzak@redhat.com \
    --cc=util-linux@vger.kernel.org \
    --cc=zeeshanak@gnome.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.