From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: yaneti@declera.com, netdev@vger.kernel.org
Subject: Re: PPPOE lockdep report in dev_queue_xmit+0x8b8/0x900
Date: Tue, 19 Feb 2013 14:34:25 -0500 (EST) [thread overview]
Message-ID: <20130219.143425.2168723550194243266.davem@davemloft.net> (raw)
In-Reply-To: <1361299323.19353.156.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 19 Feb 2013 10:42:03 -0800
> [PATCH v2] ppp: set qdisc_tx_busylock to avoid LOCKDEP splat
>
> If a qdisc is installed on a ppp device, its possible to get
> a lockdep splat under stress, because nested dev_queue_xmit() can
> lock busylock a second time (on a different device, so its a false
> positive)
>
> Avoid this problem using a distinct lock_class_key for ppp
> devices.
>
> Reported-by: Yanko Kaneti <yaneti@declera.com>
> Tested-by: Yanko Kaneti <yaneti@declera.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied and queued up for -stable, thanks Eric.
prev parent reply other threads:[~2013-02-19 19:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-18 17:43 PPPOE lockdep report in dev_queue_xmit+0x8b8/0x900 Yanko Kaneti
2013-02-18 17:43 ` Yanko Kaneti
2013-02-18 19:50 ` Eric Dumazet
2013-02-19 11:10 ` Yanko Kaneti
2013-02-19 18:42 ` Eric Dumazet
2013-02-19 19:34 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130219.143425.2168723550194243266.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=yaneti@declera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.