From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Wed, 20 Feb 2013 16:27:04 +0000 Subject: [PATCH 2/2] USB: EHCI: make ehci-orion a separate driver In-Reply-To: References: Message-ID: <201302201627.04224.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wednesday 20 February 2013, Alan Stern wrote: > Currently there is no Kconfig option to control specifically whether > the ehci-orion driver gets built; it always gets built whenever > CONFIG_PLAT_ORION and CONFIG_USB_EHCI_HCD are both enabled. > > Do you think it is a good idea to add an option for this? Should it at > least be non-interactive, so that the driver always gets built under > the same conditions as currently? A later patch can make it > interactive, if desired. I think it's good to have it interactive, because we are now building for multiplatform with Orion being one of many. It's useful to be able to build EHCI_HCD=y AND EHCD_HCD_ORION=m. However, you are right that this is a change that was not mentioned in the patch description and would better have been kept separate or at least explicitly spelled out. Arnd