From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-usb@vger.kernel.org, Tejun Heo <tj@kernel.org>,
linux-ide@vger.kernel.org, Jeff Garzik <jgarzik@pobox.com>,
Yinghai Lu <yinghai@kernel.org>
Subject: Re: [PATCH 1/2] ACPI / glue: Add .match() callback to struct acpi_bus_type
Date: Thu, 28 Feb 2013 21:07:06 -0800 [thread overview]
Message-ID: <20130301050706.GB25192@kroah.com> (raw)
In-Reply-To: <194591401.DiJi7SfL1g@vostro.rjw.lan>
On Thu, Feb 28, 2013 at 10:53:21PM +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> USB uses the .find_bridge() callback from struct acpi_bus_type
> incorrectly, because as a result of the way it is used by USB every
> device in the system that doesn't have a bus type or parent is
> passed to usb_acpi_find_device() for inspection.
>
> What USB actually needs, though, is to call usb_acpi_find_device()
> for USB ports that don't have a bus type defined, but have
> usb_port_device_type as their device type, as well as for USB
> devices.
>
> To fix that replace the struct bus_type pointer in struct
> acpi_bus_type used for matching devices to specific subsystems
> with a .match() callback to be used for this purpose and update
> the users of struct acpi_bus_type, including USB, accordingly.
> Define the .match() callback routine for USB, usb_acpi_bus_match(),
> in such a way that it will cover both USB devices and USB ports
> and remove the now redundant .find_bridge() callback pointer from
> usb_acpi_bus.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2013-03-01 5:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 22:06 [Resend][PATCH] ACPI / glue: Drop .find_bridge() callback from struct acpi_bus_type Rafael J. Wysocki
2013-02-27 22:20 ` Greg Kroah-Hartman
2013-02-27 23:31 ` Yinghai Lu
2013-02-28 0:23 ` Lan Tianyu
2013-02-28 1:19 ` Rafael J. Wysocki
2013-02-28 1:11 ` Rafael J. Wysocki
2013-02-28 2:33 ` Greg Kroah-Hartman
2013-02-28 21:49 ` Rafael J. Wysocki
2013-02-28 21:53 ` [PATCH 1/2] ACPI / glue: Add .match() callback to " Rafael J. Wysocki
2013-02-28 22:29 ` Yinghai Lu
2013-02-28 23:37 ` Rafael J. Wysocki
2013-03-01 5:07 ` Greg Kroah-Hartman [this message]
2013-02-28 21:53 ` [PATCH 2/2] ACPI / glue: Drop .find_bridge() callback from " Rafael J. Wysocki
2013-02-28 22:13 ` Jeff Garzik
2013-02-28 23:37 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130301050706.GB25192@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bhelgaas@google.com \
--cc=jgarzik@pobox.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=tj@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.