From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH 05/26] drm/i915: panel power sequencing for
 VLV eDP
Date: Fri, 8 Mar 2013 08:53:41 -0800
Message-ID: <20130308085341.31a3e067@jbarnes-desktop>
References: <1362175722-9281-1-git-send-email-jbarnes@virtuousgeek.org>
	<1362175722-9281-5-git-send-email-jbarnes@virtuousgeek.org>
	<87a9qeuhhr.fsf@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from oproxy1-pub.bluehost.com (oproxy1-pub.bluehost.com
	[66.147.249.253])
	by gabe.freedesktop.org (Postfix) with SMTP id 0587BE6E4D
	for <intel-gfx@lists.freedesktop.org>;
	Fri,  8 Mar 2013 08:53:17 -0800 (PST)
In-Reply-To: <87a9qeuhhr.fsf@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Fri, 08 Mar 2013 15:51:44 +0200
Jani Nikula <jani.nikula@linux.intel.com> wrote:

> > +	} else {
> > +		pp_control_reg = PP_CONTROL;
> > +		pp_on_reg = PP_ON_DELAYS;
> > +		pp_off_reg = PP_OFF_DELAYS;
> > +		pp_div_reg = PP_DIVISOR;
> > +	}  
> 
> Is this else branch needed? ironlake_get_pp_control() does not support
> pre-pch split hw either. Does pre-pch split hw support edp?
> 

No it isn't.  When I first looked at it I thought "what about G4x" but
then later realized that G4x only supports external DP, not embedded.
So I'll drop these hunks.

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center