From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 10/26] drm/i915: add more clock gating for VLV, allow force wake at init Date: Fri, 8 Mar 2013 19:06:00 +0200 Message-ID: <20130308170600.GD4469@intel.com> References: <1362175722-9281-1-git-send-email-jbarnes@virtuousgeek.org> <1362175722-9281-10-git-send-email-jbarnes@virtuousgeek.org> <87d2vaui1g.fsf@intel.com> <20130308085253.716ddbc3@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 17700E65AB for ; Fri, 8 Mar 2013 09:06:04 -0800 (PST) Content-Disposition: inline In-Reply-To: <20130308085253.716ddbc3@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Mar 08, 2013 at 08:52:53AM -0800, Jesse Barnes wrote: > On Fri, 08 Mar 2013 15:39:55 +0200 > Jani Nikula wrote: > = > > On Sat, 02 Mar 2013, Jesse Barnes wrote: > > > From: Ben Widawsky > > > > > > Disable all Gunit clock gating and make set the "allow force wake" bi= t. > > > > > > Signed-off-by: Jesse Barnes > > > --- > > > drivers/gpu/drm/i915/i915_gem.c | 4 ++++ > > > drivers/gpu/drm/i915/i915_reg.h | 1 + > > > drivers/gpu/drm/i915/intel_pm.c | 10 +++++++++- > > > 3 files changed, 14 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i= 915_gem.c > > > index 8413ffc..dd67698 100644 > > > --- a/drivers/gpu/drm/i915/i915_gem.c > > > +++ b/drivers/gpu/drm/i915/i915_gem.c > > > @@ -4010,7 +4010,11 @@ int i915_gem_init(struct drm_device *dev) > > > int ret; > > > = > > > mutex_lock(&dev->struct_mutex); > > > + > > > + /* VLVA0 (potential hack), BIOS isn't actually waking us */ > > > + I915_WRITE(VLV_GTLC_WAKE_CTRL, 1); > > = > > Wrap that in if IS_VALLEYVIEW(dev)? Separate this from the other hunk > > into a separate patch? > = > Ah this one did sneak in, I'll factor it out and put it under an IS_VLV > check. Maybe I asked this already but if so I'll ask again. IIRC this thing has an ack bit in another register. Should we poll it afterwards or are we sure there's a long enough delay between this and when we need forcewake? -- = Ville Syrj=E4l=E4 Intel OTC