From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754806Ab3CONZU (ORCPT ); Fri, 15 Mar 2013 09:25:20 -0400 Received: from mga02.intel.com ([134.134.136.20]:25709 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754173Ab3CONZS (ORCPT ); Fri, 15 Mar 2013 09:25:18 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.84,850,1355126400"; d="scan'208";a="279997579" From: "Kirill A. Shutemov" To: Hillf Danton Cc: "Kirill A. Shutemov" , Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: References: <1363283435-7666-1-git-send-email-kirill.shutemov@linux.intel.com> <1363283435-7666-17-git-send-email-kirill.shutemov@linux.intel.com> Subject: Re: [PATCHv2, RFC 16/30] thp: handle file pages in split_huge_page() Content-Transfer-Encoding: 7bit Message-Id: <20130315132656.BC518E0085@blue.fi.intel.com> Date: Fri, 15 Mar 2013 15:26:56 +0200 (EET) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hillf Danton wrote: > On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov > wrote: > > -int split_huge_page(struct page *page) > > +static int split_anon_huge_page(struct page *page) > > { > > struct anon_vma *anon_vma; > > int ret = 1; > > > > - BUG_ON(is_huge_zero_pfn(page_to_pfn(page))); > > - BUG_ON(!PageAnon(page)); > > - > deleted, why? split_anon_huge_page() should only be called from split_huge_page(). Probably I could bring it back, but it's kinda redundant. -- Kirill A. Shutemov From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx166.postini.com [74.125.245.166]) by kanga.kvack.org (Postfix) with SMTP id 489656B0027 for ; Fri, 15 Mar 2013 09:25:18 -0400 (EDT) From: "Kirill A. Shutemov" In-Reply-To: References: <1363283435-7666-1-git-send-email-kirill.shutemov@linux.intel.com> <1363283435-7666-17-git-send-email-kirill.shutemov@linux.intel.com> Subject: Re: [PATCHv2, RFC 16/30] thp: handle file pages in split_huge_page() Content-Transfer-Encoding: 7bit Message-Id: <20130315132656.BC518E0085@blue.fi.intel.com> Date: Fri, 15 Mar 2013 15:26:56 +0200 (EET) Sender: owner-linux-mm@kvack.org List-ID: To: Hillf Danton Cc: "Kirill A. Shutemov" , Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Hillf Danton wrote: > On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov > wrote: > > -int split_huge_page(struct page *page) > > +static int split_anon_huge_page(struct page *page) > > { > > struct anon_vma *anon_vma; > > int ret = 1; > > > > - BUG_ON(is_huge_zero_pfn(page_to_pfn(page))); > > - BUG_ON(!PageAnon(page)); > > - > deleted, why? split_anon_huge_page() should only be called from split_huge_page(). Probably I could bring it back, but it's kinda redundant. -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org