From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755364Ab3CONed (ORCPT ); Fri, 15 Mar 2013 09:34:33 -0400 Received: from mga02.intel.com ([134.134.136.20]:56115 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754919Ab3CONeb (ORCPT ); Fri, 15 Mar 2013 09:34:31 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.84,850,1355126400"; d="scan'208";a="302741820" From: "Kirill A. Shutemov" To: Hillf Danton Cc: "Kirill A. Shutemov" , Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: References: <1363283435-7666-1-git-send-email-kirill.shutemov@linux.intel.com> <1363283435-7666-14-git-send-email-kirill.shutemov@linux.intel.com> <20130315132440.C4DF8E0085@blue.fi.intel.com> Subject: Re: [PATCHv2, RFC 13/30] thp, mm: implement grab_cache_huge_page_write_begin() Content-Transfer-Encoding: 7bit Message-Id: <20130315133543.E0865E0085@blue.fi.intel.com> Date: Fri, 15 Mar 2013 15:35:43 +0200 (EET) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hillf Danton wrote: > On Fri, Mar 15, 2013 at 9:24 PM, Kirill A. Shutemov > wrote: > > Hillf Danton wrote: > >> On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov > >> wrote: > >> > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE > >> > +struct page *grab_cache_huge_page_write_begin(struct address_space *mapping, > >> > + pgoff_t index, unsigned flags); > >> > +#else > >> > +static inline struct page *grab_cache_huge_page_write_begin( > >> > + struct address_space *mapping, pgoff_t index, unsigned flags) > >> > +{ > >> build bug? > > > > Hm?. No. Why? > > > Stop build if THP not configured? No. I've tested it without CONFIG_TRANSPARENT_HUGEPAGE. -- Kirill A. Shutemov From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kirill A. Shutemov" Subject: Re: [PATCHv2, RFC 13/30] thp, mm: implement grab_cache_huge_page_write_begin() Date: Fri, 15 Mar 2013 15:35:43 +0200 (EET) Message-ID: <20130315133543.E0865E0085@blue.fi.intel.com> References: <1363283435-7666-1-git-send-email-kirill.shutemov@linux.intel.com> <1363283435-7666-14-git-send-email-kirill.shutemov@linux.intel.com> <20130315132440.C4DF8E0085@blue.fi.intel.com> Content-Transfer-Encoding: 7bit Cc: "Kirill A. Shutemov" , Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Hillf Danton Return-path: In-Reply-To: Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org Hillf Danton wrote: > On Fri, Mar 15, 2013 at 9:24 PM, Kirill A. Shutemov > wrote: > > Hillf Danton wrote: > >> On Fri, Mar 15, 2013 at 1:50 AM, Kirill A. Shutemov > >> wrote: > >> > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE > >> > +struct page *grab_cache_huge_page_write_begin(struct address_space *mapping, > >> > + pgoff_t index, unsigned flags); > >> > +#else > >> > +static inline struct page *grab_cache_huge_page_write_begin( > >> > + struct address_space *mapping, pgoff_t index, unsigned flags) > >> > +{ > >> build bug? > > > > Hm?. No. Why? > > > Stop build if THP not configured? No. I've tested it without CONFIG_TRANSPARENT_HUGEPAGE. -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org