From: Jeff Layton <jlayton@redhat.com>
To: Joe Perches <joe@perches.com>
Cc: Steve French <sfrench@samba.org>,
linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cifs: Rename cERROR and cFYI to cifs_dbg
Date: Fri, 15 Mar 2013 14:56:29 -0400 [thread overview]
Message-ID: <20130315145629.2e1a04c5@tlielax.poochiereds.net> (raw)
In-Reply-To: <1363289077.2146.19.camel@joe-AO722>
On Thu, 14 Mar 2013 12:24:37 -0700
Joe Perches <joe@perches.com> wrote:
> It's not obvious from reading the macro names that these macros
> are for debugging. Convert the names to a single more typical
> kernel style cifs_dbg macro.
>
> cERROR(1, ...) -> cifs_dbg(VFS, ...)
> cFYI(1, ...) -> cifs_dbg(FYI, ...)
> cFYI(DBG2, ...) -> cifs_dbg(NOISY, ...)
>
> Move the terminating format newline from the macro to the call site.
>
> Add CONFIG_CIFS_DEBUG function cifs_vfs_err to emit the
> "CIFS VFS: " prefix for VFS messages.
>
> Size is reduced ~ 1% when CONFIG_CIFS_DEBUG is set (default y)
>
> $ size fs/cifs/cifs.ko*
> text data bss dec hex filename
> 265245 2525 132 267902 4167e fs/cifs/cifs.ko.new
> 268359 2525 132 271016 422a8 fs/cifs/cifs.ko.old
>
This all looks like good stuff. I am a bit concerned about mashing all
of these cleanups into the same patch though.
> Other miscellaneous changes around these conversions:
>
> o Miscellaneous typo fixes
> o Add terminating \n's to almost all formats and remove them
> from the macros to be more kernel style like. A few formats
> previously had defective \n's
> o Remove unnecessary OOM messages as kmalloc() calls dump_stack
> o Coalesce formats to make grep easier,
> added missing spaces when coalescing formats
> o Use %s, __func__ instead of embedded function name
> o Removed unnecessary "cifs: " prefixes
> o Convert kzalloc with multiply to kcalloc
> o Remove unused cifswarn macro
>
--
Jeff Layton <jlayton@redhat.com>
next prev parent reply other threads:[~2013-03-15 18:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 22:44 [PATCH] cifs: Rename cERROR and cifserror to cifs_vfs_err Joe Perches
2013-03-13 11:36 ` Joe Perches
2013-03-13 11:36 ` Joe Perches
2013-03-13 11:51 ` Jeff Layton
2013-03-13 11:51 ` Jeff Layton
[not found] ` <20130313075155.7464a34a-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2013-03-13 12:40 ` Joe Perches
2013-03-13 12:40 ` Joe Perches
2013-03-14 19:24 ` [PATCH] cifs: Rename cERROR and cFYI to cifs_dbg Joe Perches
2013-03-15 18:56 ` Jeff Layton [this message]
2013-03-15 19:01 ` Jeff Layton
2013-03-15 19:01 ` Jeff Layton
[not found] ` <CAH2r5mvW29FV+stH5CsjY5S2FdaHn48TfiSEk_beC=NzHC7-MQ@mail.gmail.com>
[not found] ` <CAH2r5mvW29FV+stH5CsjY5S2FdaHn48TfiSEk_beC=NzHC7-MQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-03-15 20:43 ` Joe Perches
2013-03-15 20:43 ` Joe Perches
2013-03-25 4:44 ` Steve French
2013-03-25 4:44 ` Steve French
2013-03-15 21:46 ` Fwd: " Steve French
2013-03-15 21:46 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130315145629.2e1a04c5@tlielax.poochiereds.net \
--to=jlayton@redhat.com \
--cc=joe@perches.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.