From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 12/15] drm/i915: reorganize intel_lvds_supported Date: Fri, 15 Mar 2013 13:57:52 -0700 Message-ID: <20130315205752.GL17773@bwidawsk.net> References: <1362611003-4823-1-git-send-email-przanoni@gmail.com> <1362611003-4823-13-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from shiva.localdomain (209-20-75-48.static.cloud-ips.com [209.20.75.48]) by gabe.freedesktop.org (Postfix) with ESMTP id 26AA1E5DE2 for ; Fri, 15 Mar 2013 13:57:56 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1362611003-4823-13-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Wed, Mar 06, 2013 at 08:03:19PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > Now it returns false for all platforms unless they're explicitly > listed on the function. There should be no real difference, except for > the fact that it now returns false on Haswell. > > Signed-off-by: Paulo Zanoni I wouldn't mind comments in the commit or code reminding me that IBX and CPT cover ILk->IVB, and gm45 counts as gen4, but that's just 'cause I have a bad memory. Reviewed-by: Ben Widawsky > --- > drivers/gpu/drm/i915/intel_lvds.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c > index 6b24fc5..53bd5fd 100644 > --- a/drivers/gpu/drm/i915/intel_lvds.c > +++ b/drivers/gpu/drm/i915/intel_lvds.c > @@ -1020,15 +1020,15 @@ static bool intel_lvds_supported(struct drm_device *dev) > { > /* With the introduction of the PCH we gained a dedicated > * LVDS presence pin, use it. */ > - if (HAS_PCH_SPLIT(dev)) > + if (HAS_PCH_IBX(dev) || HAS_PCH_CPT(dev)) > return true; > > - if (IS_VALLEYVIEW(dev)) > - return false; > - > /* Otherwise LVDS was only attached to mobile products, > * except for the inglorious 830gm */ > - return IS_MOBILE(dev) && !IS_I830(dev); > + if (INTEL_INFO(dev)->gen <= 4 && IS_MOBILE(dev) && !IS_I830(dev)) > + return true; > + > + return false; > } -- Ben Widawsky, Intel Open Source Technology Center