From: Johan Hedberg <johan.hedberg@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v4 07/26] Bluetooth: Add a define for the HCI persistent flags mask
Date: Fri, 15 Mar 2013 16:34:09 -0500 [thread overview]
Message-ID: <20130315213409.GA24055@x220.dfw6.dal.wayport.net> (raw)
In-Reply-To: <035D9C11-5F66-4584-AB2C-86DA558E2A2E@holtmann.org>
Hi Marcel,
On Fri, Mar 15, 2013, Marcel Holtmann wrote:
> > +/* A mask for the flags that are supposed to remain when a reset happens
> > + * or the HCI device is closed.
> > + */
> > +#define HCI_PERSISTENT_MASK ~(BIT(HCI_LE_SCAN) | BIT(HCI_PERIODIC_INQ))
> > +
>
> didn't we agree and getting this fixed and moving the ~ to the actual call.
Yes we did. I just forgot about it, sorry. v5 of this patch coming in a
minute.
Johan
next prev parent reply other threads:[~2013-03-15 21:34 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 18:11 [PATCH v4 00/26] Bluetooth: Management interface fixes Johan Hedberg
2013-03-13 18:11 ` [PATCH v4 01/26] Bluetooth: Move power on HCI command updates to their own function Johan Hedberg
2013-03-13 18:11 ` [PATCH v4 02/26] Bluetooth: Update mgmt powered HCI commands to use async requests Johan Hedberg
2013-03-13 18:11 ` [PATCH v4 03/26] Bluetooth: Wait for HCI command completion with mgmt_set_powered Johan Hedberg
2013-03-13 18:11 ` [PATCH v4 04/26] Bluetooth: Fix busy condition testing for EIR and class updates Johan Hedberg
2013-03-13 18:11 ` [PATCH v4 05/26] Bluetooth: Fix UUID/class mgmt command response synchronization Johan Hedberg
2013-03-13 18:11 ` [PATCH v4 06/26] Bluetooth: Remove useless HCI_PENDING_CLASS flag Johan Hedberg
2013-03-13 18:11 ` [PATCH v4 07/26] Bluetooth: Add a define for the HCI persistent flags mask Johan Hedberg
2013-03-15 20:23 ` Marcel Holtmann
2013-03-15 21:34 ` Johan Hedberg [this message]
2013-03-13 18:11 ` [PATCH v4 08/26] Bluetooth: Clear non-persistent flags when closing HCI device Johan Hedberg
2013-03-13 18:12 ` [PATCH v4 09/26] Bluetooth: Fix clearing flags on power off before notifying mgmt Johan Hedberg
2013-03-13 18:12 ` [PATCH v4 10/26] Bluetooth: Fix waiting for EIR update when setting local name Johan Hedberg
2013-03-13 18:12 ` [PATCH v4 11/26] Bluetooth: Handle AD updating through an async request Johan Hedberg
2013-03-13 18:12 ` [PATCH v4 12/26] Bluetooth: Fix local name setting for LE-only controllers Johan Hedberg
2013-03-13 18:12 ` [PATCH v4 13/26] Bluetooth: Fix setting local name to the existing value Johan Hedberg
2013-03-13 18:12 ` [PATCH v4 14/26] Bluetooth: Use an async request for mgmt_set_connectable Johan Hedberg
2013-03-13 18:12 ` [PATCH v4 15/26] Bluetooth: Fix fast connectable response sending Johan Hedberg
2013-03-13 18:12 ` [PATCH v4 16/26] Bluetooth: Limit fast connectable support to >= 1.2 controllers Johan Hedberg
2013-03-13 18:12 ` [PATCH v4 17/26] Bluetooth: Fix error response for simultaneous fast connectable commands Johan Hedberg
2013-03-13 18:12 ` [PATCH v4 18/26] Bluetooth: Add proper flag for fast connectable mode Johan Hedberg
2013-03-13 18:12 ` [PATCH v4 19/26] Bluetooth: Refactor fast connectable HCI commands Johan Hedberg
2013-03-13 18:12 ` [PATCH v4 20/26] Bluetooth: Disable fast connectable when disabling connectable Johan Hedberg
2013-03-13 18:12 ` [PATCH v4 21/26] Bluetooth: Add reading of page scan parameters Johan Hedberg
2013-03-13 18:12 ` [PATCH v4 22/26] Bluetooth: Update page scan parameters after successful write commands Johan Hedberg
2013-03-13 18:12 ` [PATCH v4 23/26] Bluetooth: Fix updating page scan parameters when not necessary Johan Hedberg
2013-03-13 18:12 ` [PATCH v4 24/26] Bluetooth: Fix fast connectable state when enabling page scan Johan Hedberg
2013-03-13 18:12 ` [PATCH v4 25/26] Bluetooth: Simplify address parameters of user_pairing_resp() Johan Hedberg
2013-03-13 18:12 ` [PATCH v4 26/26] Bluetooth: Fix PIN/Confirm/Passkey response parameters Johan Hedberg
2013-03-15 20:29 ` [PATCH v4 00/26] Bluetooth: Management interface fixes Marcel Holtmann
2013-03-15 23:09 ` Scott James Remnant
2013-03-15 23:14 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130315213409.GA24055@x220.dfw6.dal.wayport.net \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.