From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 02/15] drm/i915: disable sound first on intel_disable_ddi Date: Sun, 17 Mar 2013 21:25:01 +0100 Message-ID: <20130317202501.GK9021@phenom.ffwll.local> References: <1362611003-4823-1-git-send-email-przanoni@gmail.com> <1362611003-4823-3-git-send-email-przanoni@gmail.com> <20130315182402.GC17773@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f43.google.com (mail-ee0-f43.google.com [74.125.83.43]) by gabe.freedesktop.org (Postfix) with ESMTP id 3BAAFE5D74 for ; Sun, 17 Mar 2013 13:22:16 -0700 (PDT) Received: by mail-ee0-f43.google.com with SMTP id c50so2369375eek.16 for ; Sun, 17 Mar 2013 13:22:15 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130315182402.GC17773@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Fri, Mar 15, 2013 at 11:24:03AM -0700, Ben Widawsky wrote: > On Wed, Mar 06, 2013 at 08:03:09PM -0300, Paulo Zanoni wrote: > > From: Paulo Zanoni > > > > Our mode set sequence documentation says audio must be disabled before > > the backlight. > > > > Signed-off-by: Paulo Zanoni > > At least what I see it says, Audio must be disabled, "first." So I'd > recommend modifying the commit message to not mention backlight > specifically > > Reviewed-by: Ben Widawsky Queued for -next with Ben's bikeshed, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch