From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753736Ab3CRSKU (ORCPT ); Mon, 18 Mar 2013 14:10:20 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:60095 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751891Ab3CRSKS (ORCPT ); Mon, 18 Mar 2013 14:10:18 -0400 Date: Mon, 18 Mar 2013 14:08:10 -0400 (EDT) Message-Id: <20130318.140810.1336756541135122611.davem@davemloft.net> To: silviupopescu1990@gmail.com Cc: linux-bluetooth@vger.kernel.org, marcel@holtmann.org, gustavo@padovan.org, johan.hedberg@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] bluetooth: use PTR_RET instead of IS_ERR + PTR_ERR From: David Miller In-Reply-To: References: <1363111995-26866-1-git-send-email-silviupopescu1990@gmail.com> <20130313.053145.2200448840921851390.davem@davemloft.net> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (shards.monkeyblade.net [0.0.0.0]); Mon, 18 Mar 2013 11:10:21 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Silviu Popescu Date: Mon, 18 Mar 2013 20:05:42 +0200 >>> + return PTR_RET(bt_class) .. > That being said, I'd like to understand a bit better what exactly I messed up. There's no semicolon at the end of the return statement. From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] bluetooth: use PTR_RET instead of IS_ERR + PTR_ERR Date: Mon, 18 Mar 2013 14:08:10 -0400 (EDT) Message-ID: <20130318.140810.1336756541135122611.davem@davemloft.net> References: <1363111995-26866-1-git-send-email-silviupopescu1990@gmail.com> <20130313.053145.2200448840921851390.davem@davemloft.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org, gustavo-THi1TnShQwVAfugRpC6u6w@public.gmane.org, johan.hedberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: silviupopescu1990-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Return-path: In-Reply-To: Sender: linux-bluetooth-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org From: Silviu Popescu Date: Mon, 18 Mar 2013 20:05:42 +0200 >>> + return PTR_RET(bt_class) .. > That being said, I'd like to understand a bit better what exactly I messed up. There's no semicolon at the end of the return statement.