From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753254Ab3CRLSE (ORCPT ); Mon, 18 Mar 2013 07:18:04 -0400 Received: from mga01.intel.com ([192.55.52.88]:52931 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751577Ab3CRLR7 (ORCPT ); Mon, 18 Mar 2013 07:17:59 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.84,863,1355126400"; d="scan'208";a="308121418" From: "Kirill A. Shutemov" To: Simon Jeons Cc: "Kirill A. Shutemov" , Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <5146A4CC.3060306@gmail.com> References: <1363283435-7666-1-git-send-email-kirill.shutemov@linux.intel.com> <514691F5.2040204@gmail.com> <5146A4CC.3060306@gmail.com> Subject: Re: [PATCHv2, RFC 00/30] Transparent huge page cache Content-Transfer-Encoding: 7bit Message-Id: <20130318111939.C8206E0085@blue.fi.intel.com> Date: Mon, 18 Mar 2013 13:19:39 +0200 (EET) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Simon Jeons wrote: > On 03/18/2013 12:03 PM, Simon Jeons wrote: > > Hi Kirill, > > On 03/15/2013 01:50 AM, Kirill A. Shutemov wrote: > >> From: "Kirill A. Shutemov" > >> > >> Here's the second version of the patchset. > >> > >> The intend of the work is get code ready to enable transparent huge page > >> cache for the most simple fs -- ramfs. > >> > >> We have read()/write()/mmap() functionality now. Still plenty work > >> ahead. > > > > One offline question. > > > > Why set PG_mlocked to page_tail which be splited in function > > __split_huge_page_refcount? Not set, but copied from head page. Head page represents up-to-date sate of compound page, we need to copy it to all tail pages on split. > Also why can't find where _PAGE_SPLITTING and _PAGE_PSE flags are > cleared in split_huge_page path? The pmd is invalidated and replaced with reference to page table at the end of __split_huge_page_map. > Another offline question: > Why don't clear tail page PG_tail flag in function > __split_huge_page_refcount? We do: page_tail->flags &= ~PAGE_FLAGS_CHECK_AT_PREP | __PG_HWPOISON; -- Kirill A. Shutemov From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kirill A. Shutemov" Subject: Re: [PATCHv2, RFC 00/30] Transparent huge page cache Date: Mon, 18 Mar 2013 13:19:39 +0200 (EET) Message-ID: <20130318111939.C8206E0085@blue.fi.intel.com> References: <1363283435-7666-1-git-send-email-kirill.shutemov@linux.intel.com> <514691F5.2040204@gmail.com> <5146A4CC.3060306@gmail.com> Content-Transfer-Encoding: 7bit Cc: "Kirill A. Shutemov" , Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Simon Jeons Return-path: In-Reply-To: <5146A4CC.3060306@gmail.com> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org Simon Jeons wrote: > On 03/18/2013 12:03 PM, Simon Jeons wrote: > > Hi Kirill, > > On 03/15/2013 01:50 AM, Kirill A. Shutemov wrote: > >> From: "Kirill A. Shutemov" > >> > >> Here's the second version of the patchset. > >> > >> The intend of the work is get code ready to enable transparent huge page > >> cache for the most simple fs -- ramfs. > >> > >> We have read()/write()/mmap() functionality now. Still plenty work > >> ahead. > > > > One offline question. > > > > Why set PG_mlocked to page_tail which be splited in function > > __split_huge_page_refcount? Not set, but copied from head page. Head page represents up-to-date sate of compound page, we need to copy it to all tail pages on split. > Also why can't find where _PAGE_SPLITTING and _PAGE_PSE flags are > cleared in split_huge_page path? The pmd is invalidated and replaced with reference to page table at the end of __split_huge_page_map. > Another offline question: > Why don't clear tail page PG_tail flag in function > __split_huge_page_refcount? We do: page_tail->flags &= ~PAGE_FLAGS_CHECK_AT_PREP | __PG_HWPOISON; -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org