From: Mukesh Rathor <mukesh.rathor@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH 11/18 V2]: PVH xen: some misc changes like mtrr, intr, msi.
Date: Mon, 18 Mar 2013 18:20:18 -0700 [thread overview]
Message-ID: <20130318182018.2fd92acb@mantra.us.oracle.com> (raw)
In-Reply-To: <514714C702000078000C6590@nat28.tlf.novell.com>
On Mon, 18 Mar 2013 12:21:11 +0000
"Jan Beulich" <JBeulich@suse.com> wrote:
> >>> On 16.03.13 at 01:46, Mukesh Rathor <mukesh.rathor@oracle.com>
> >>> wrote:
> > +++ b/xen/arch/x86/msi.c
> > @@ -787,10 +787,15 @@ static int msix_capability_init(struct
> > pci_dev *dev,
> > if ( !dev->msix_used_entries )
> > {
> > - if ( rangeset_add_range(mmio_ro_ranges,
> > dev->msix_table.first,
> > + /* PVH: this is temporary only until linux msi.c is fixed.
> > See xen-devel
> > + * thread: "[PVH]: Help: msi.c".
> > + */
> > + if ( !is_pvh_domain(dev->domain) &&
> > + rangeset_add_range(mmio_ro_ranges,
> > dev->msix_table.first, dev->msix_table.last) )
> > WARN();
> > - if ( rangeset_add_range(mmio_ro_ranges,
> > dev->msix_pba.first,
> > + if ( !is_pvh_domain(dev->domain) &&
> > + rangeset_add_range(mmio_ro_ranges,
> > dev->msix_pba.first, dev->msix_pba.last) )
> > WARN();
> >
>
> As already said before, the whole change above has my explicit
> NAK.
> Jan
Do you have any suggestions? Do you want to hold off on entire xen patch
until we go fix linux for this? Or can we just omit this change in the next
V 3 and come back to this later. Would you be OK with that?
thanks
MR
next prev parent reply other threads:[~2013-03-19 1:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-16 0:46 [PATCH 11/18 V2]: PVH xen: some misc changes like mtrr, intr, msi Mukesh Rathor
2013-03-18 12:21 ` Jan Beulich
2013-03-19 1:20 ` Mukesh Rathor [this message]
2013-03-19 8:55 ` Jan Beulich
2013-03-19 14:11 ` Konrad Rzeszutek Wilk
2013-03-18 17:03 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130318182018.2fd92acb@mantra.us.oracle.com \
--to=mukesh.rathor@oracle.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.