From: Stephen Hemminger <stephen@networkplumber.org>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: David Miller <davem@davemloft.net>,
pshelar@nicira.com, netdev@vger.kernel.org, jesse@nicira.com
Subject: Re: [PATCH v2 net-next 1/5] GRE: Refactor GRE tunneling code.
Date: Tue, 19 Mar 2013 13:58:28 -0700 [thread overview]
Message-ID: <20130319135828.0dd18d40@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <87r4jb1y0t.fsf@nemi.mork.no>
On Tue, 19 Mar 2013 11:31:30 +0100
Bjørn Mork <bjorn@mork.no> wrote:
> David Miller <davem@davemloft.net> writes:
> > From: Stephen Hemminger <stephen@networkplumber.org>
> >> On Mon, 18 Mar 2013 11:13:25 -0700
> >> Pravin B Shelar <pshelar@nicira.com> wrote:
> >>
> >>> diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
> >>> index 7944df7..2073226 100644
> >>> --- a/net/ipv4/Kconfig
> >>> +++ b/net/ipv4/Kconfig
> >>> @@ -186,9 +186,14 @@ config NET_IPGRE_DEMUX
> >>> This is helper module to demultiplex GRE packets on GRE version field criteria.
> >>> Required by ip_gre and pptp modules.
> >>>
> >>> +config NET_IP_TUNNEL
> >>> + tristate
> >>> + default n
> >>> +
> >>
> >> Won't this break existing kernel config's, shouldn't this default y?
> >
> > Or "m". But indeed, it should be made to automatically work for
> > existing configs.
>
> Won't the "select NET_IP_TUNNEL" statements do just that?
>
> Changing the default to m will enable this module even if all of
> NET_IPGRE, VXLAN and NET_IPIP are disabled. That's pointless, isn't it?
Looks like you are right, just tried a number of different kernel
configs with 'make oldconfig' and it picks up the dependency correctly.
next prev parent reply other threads:[~2013-03-19 20:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-18 18:13 [PATCH v2 net-next 1/5] GRE: Refactor GRE tunneling code Pravin B Shelar
2013-03-18 19:23 ` David Miller
2013-03-18 19:24 ` David Miller
2013-03-18 19:24 ` Stephen Hemminger
2013-03-18 19:33 ` David Miller
2013-03-19 3:11 ` Pravin Shelar
2013-03-19 10:31 ` Bjørn Mork
2013-03-19 20:58 ` Stephen Hemminger [this message]
2013-03-19 21:21 ` Stephen Hemminger
2013-03-19 21:26 ` David Miller
2013-03-19 21:38 ` Pravin Shelar
2013-03-19 21:56 ` David Miller
2013-03-25 19:30 ` Pravin Shelar
2013-03-25 19:39 ` David Miller
2013-03-25 20:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130319135828.0dd18d40@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=jesse@nicira.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.