From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ezequiel Garcia Subject: Re: [PATCH 05/16] thermal: mvebu: Fix valid check for thermal register Date: Thu, 21 Mar 2013 12:16:10 -0300 Message-ID: <20130321151609.GA24246@localhost> References: <1363818997-23137-1-git-send-email-ezequiel.garcia@free-electrons.com> <1363818997-23137-6-git-send-email-ezequiel.garcia@free-electrons.com> <20130321143539.GV13280@titan.lakedaemon.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail.free-electrons.com ([94.23.35.102]:53850 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754656Ab3CUPQT (ORCPT ); Thu, 21 Mar 2013 11:16:19 -0400 Content-Disposition: inline In-Reply-To: <20130321143539.GV13280@titan.lakedaemon.net> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Jason Cooper Cc: linux-arm-kernel@lists.infradead.org, Zhang Rui , linux-pm@vger.kernel.org, Thomas Petazzoni , Gregory Clement , Nobuhiro Iwamatsu , Andrew Lunn , Florian Fainelli , Sebastian Hesselbarth , Lior Amsalem Hi Jason, On Thu, Mar 21, 2013 at 10:35:39AM -0400, Jason Cooper wrote: > On Wed, Mar 20, 2013 at 07:36:26PM -0300, Ezequiel Garcia wrote: > > The correct value is obtain by first shifting the register by the o= ffset, > > later applying the valid mask and finally invert the result. > > This check was lacking an extra parenthesis to be strictly correct. > >=20 > > Signed-off-by: Ezequiel Garcia > > --- > > drivers/thermal/mvebu_thermal.c | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) >=20 > For the next version of this series, could you please put this fix fi= rst > in the series? In this state, it can't be applied to v3.9-rcX, nor > -stable. >=20 Given we're still discussing the aproach of this patchset. I think I prefer to send the fixes now, not as part of the current series but as independent patches. What do you think? --=20 Ezequiel Garc=C3=ADa, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia) Date: Thu, 21 Mar 2013 12:16:10 -0300 Subject: [PATCH 05/16] thermal: mvebu: Fix valid check for thermal register In-Reply-To: <20130321143539.GV13280@titan.lakedaemon.net> References: <1363818997-23137-1-git-send-email-ezequiel.garcia@free-electrons.com> <1363818997-23137-6-git-send-email-ezequiel.garcia@free-electrons.com> <20130321143539.GV13280@titan.lakedaemon.net> Message-ID: <20130321151609.GA24246@localhost> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Jason, On Thu, Mar 21, 2013 at 10:35:39AM -0400, Jason Cooper wrote: > On Wed, Mar 20, 2013 at 07:36:26PM -0300, Ezequiel Garcia wrote: > > The correct value is obtain by first shifting the register by the offset, > > later applying the valid mask and finally invert the result. > > This check was lacking an extra parenthesis to be strictly correct. > > > > Signed-off-by: Ezequiel Garcia > > --- > > drivers/thermal/mvebu_thermal.c | 4 ++-- > > 1 files changed, 2 insertions(+), 2 deletions(-) > > For the next version of this series, could you please put this fix first > in the series? In this state, it can't be applied to v3.9-rcX, nor > -stable. > Given we're still discussing the aproach of this patchset. I think I prefer to send the fixes now, not as part of the current series but as independent patches. What do you think? -- Ezequiel Garc?a, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com