From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Cooper Subject: Re: [PATCH 05/16] thermal: mvebu: Fix valid check for thermal register Date: Thu, 21 Mar 2013 11:24:00 -0400 Message-ID: <20130321152400.GX13280@titan.lakedaemon.net> References: <1363818997-23137-1-git-send-email-ezequiel.garcia@free-electrons.com> <1363818997-23137-6-git-send-email-ezequiel.garcia@free-electrons.com> <20130321143539.GV13280@titan.lakedaemon.net> <20130321151609.GA24246@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:63681 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751051Ab3CUPYL (ORCPT ); Thu, 21 Mar 2013 11:24:11 -0400 Content-Disposition: inline In-Reply-To: <20130321151609.GA24246@localhost> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Ezequiel Garcia Cc: linux-arm-kernel@lists.infradead.org, Zhang Rui , linux-pm@vger.kernel.org, Thomas Petazzoni , Gregory Clement , Nobuhiro Iwamatsu , Andrew Lunn , Florian Fainelli , Sebastian Hesselbarth , Lior Amsalem On Thu, Mar 21, 2013 at 12:16:10PM -0300, Ezequiel Garcia wrote: > Hi Jason, > > On Thu, Mar 21, 2013 at 10:35:39AM -0400, Jason Cooper wrote: > > On Wed, Mar 20, 2013 at 07:36:26PM -0300, Ezequiel Garcia wrote: > > > The correct value is obtain by first shifting the register by the offset, > > > later applying the valid mask and finally invert the result. > > > This check was lacking an extra parenthesis to be strictly correct. > > > > > > Signed-off-by: Ezequiel Garcia > > > --- > > > drivers/thermal/mvebu_thermal.c | 4 ++-- > > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > For the next version of this series, could you please put this fix first > > in the series? In this state, it can't be applied to v3.9-rcX, nor > > -stable. > > > > Given we're still discussing the aproach of this patchset. > I think I prefer to send the fixes now, not as part of the > current series but as independent patches. > > What do you think? I agree. thx, Jason. From mboxrd@z Thu Jan 1 00:00:00 1970 From: jason@lakedaemon.net (Jason Cooper) Date: Thu, 21 Mar 2013 11:24:00 -0400 Subject: [PATCH 05/16] thermal: mvebu: Fix valid check for thermal register In-Reply-To: <20130321151609.GA24246@localhost> References: <1363818997-23137-1-git-send-email-ezequiel.garcia@free-electrons.com> <1363818997-23137-6-git-send-email-ezequiel.garcia@free-electrons.com> <20130321143539.GV13280@titan.lakedaemon.net> <20130321151609.GA24246@localhost> Message-ID: <20130321152400.GX13280@titan.lakedaemon.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Mar 21, 2013 at 12:16:10PM -0300, Ezequiel Garcia wrote: > Hi Jason, > > On Thu, Mar 21, 2013 at 10:35:39AM -0400, Jason Cooper wrote: > > On Wed, Mar 20, 2013 at 07:36:26PM -0300, Ezequiel Garcia wrote: > > > The correct value is obtain by first shifting the register by the offset, > > > later applying the valid mask and finally invert the result. > > > This check was lacking an extra parenthesis to be strictly correct. > > > > > > Signed-off-by: Ezequiel Garcia > > > --- > > > drivers/thermal/mvebu_thermal.c | 4 ++-- > > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > For the next version of this series, could you please put this fix first > > in the series? In this state, it can't be applied to v3.9-rcX, nor > > -stable. > > > > Given we're still discussing the aproach of this patchset. > I think I prefer to send the fixes now, not as part of the > current series but as independent patches. > > What do you think? I agree. thx, Jason.