From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751387Ab3CURRn (ORCPT ); Thu, 21 Mar 2013 13:17:43 -0400 Received: from mga14.intel.com ([143.182.124.37]:29025 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750916Ab3CURRl (ORCPT ); Thu, 21 Mar 2013 13:17:41 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.84,887,1355126400"; d="scan'208";a="274197684" From: "Kirill A. Shutemov" To: Dave Hansen Cc: "Kirill A. Shutemov" , Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <514B1D32.5030400@sr71.net> References: <1363283435-7666-1-git-send-email-kirill.shutemov@linux.intel.com> <1363283435-7666-2-git-send-email-kirill.shutemov@linux.intel.com> <514B1D32.5030400@sr71.net> Subject: Re: [PATCHv2, RFC 01/30] block: implement add_bdi_stat() Content-Transfer-Encoding: 7bit Message-Id: <20130321171923.80B4DE0085@blue.fi.intel.com> Date: Thu, 21 Mar 2013 19:19:23 +0200 (EET) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dave Hansen wrote: > On 03/14/2013 10:50 AM, Kirill A. Shutemov wrote: > > From: "Kirill A. Shutemov" > > > > It's required for batched stats update. > > The description here is a little terse. Could you at least also > describe how and where it's going to get used in later patches? Just a > sentence or two more would be really helpful. > > You might also mention that it's essentially a clone of dec_bdi_stat(). Okay. Will update the description. Thanks. -- Kirill A. Shutemov From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx167.postini.com [74.125.245.167]) by kanga.kvack.org (Postfix) with SMTP id DCEEB6B0036 for ; Thu, 21 Mar 2013 13:17:59 -0400 (EDT) From: "Kirill A. Shutemov" In-Reply-To: <514B1D32.5030400@sr71.net> References: <1363283435-7666-1-git-send-email-kirill.shutemov@linux.intel.com> <1363283435-7666-2-git-send-email-kirill.shutemov@linux.intel.com> <514B1D32.5030400@sr71.net> Subject: Re: [PATCHv2, RFC 01/30] block: implement add_bdi_stat() Content-Transfer-Encoding: 7bit Message-Id: <20130321171923.80B4DE0085@blue.fi.intel.com> Date: Thu, 21 Mar 2013 19:19:23 +0200 (EET) Sender: owner-linux-mm@kvack.org List-ID: To: Dave Hansen Cc: "Kirill A. Shutemov" , Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Dave Hansen wrote: > On 03/14/2013 10:50 AM, Kirill A. Shutemov wrote: > > From: "Kirill A. Shutemov" > > > > It's required for batched stats update. > > The description here is a little terse. Could you at least also > describe how and where it's going to get used in later patches? Just a > sentence or two more would be really helpful. > > You might also mention that it's essentially a clone of dec_bdi_stat(). Okay. Will update the description. Thanks. -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org