All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: afleming@freescale.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net: Add support for handling queueing in hardware
Date: Fri, 22 Mar 2013 10:11:39 -0400 (EDT)	[thread overview]
Message-ID: <20130322.101139.1942128058226201237.davem@davemloft.net> (raw)
In-Reply-To: <E1UJ1fR-0004hs-4l@swissweb.swissdisk.com>

From: Andy Fleming <afleming@freescale.com>
Date: Wed, 13 Jul 2011 08:52:04 -0500

> The QDisc code does a bunch of locking which is unnecessary if
> you have hardware which handles all of the queueing. Add
> support for this, and skip over all of the queueing code if
> the feature is enabled on a given device, which breaks QDisc
> support on dpaa_eth, and also coopts the FCOE feature bit.
> 
> Signed-off-by: Andy Fleming <afleming@freescale.com>
> Signed-off-by: Ben Collins <ben.c@servergy.com>

Sorry, no.

If we are going to support something like this then there needs to
be full coordination, configuration wise, so that if we enable
a qdisc that the hardware supports we submit it directly, but if
we enable a qdisc the HW does not support, we still use the software
qdisc.

This also means that we need to have a way to determine if the qdisc
configuration exceeds that parametorial limits of the device's HW
capabilities, and fallback to software qdisc in those cases too.

  reply	other threads:[~2013-03-22 14:11 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-13 13:52 [PATCH] net: Add support for handling queueing in hardware Andy Fleming
2013-03-22 14:11 ` David Miller [this message]
2013-03-22 14:31   ` Fleming Andy-AFLEMING
2013-03-22 14:33     ` David Miller
2013-03-22 14:43       ` Ben Collins
2013-03-22 15:17         ` David Miller
2013-03-22 15:39           ` Ben Collins
2013-03-22 15:41             ` David Miller
2013-03-22 15:53               ` Ben Collins
2013-03-22 15:59                 ` David Miller
2013-03-22 16:14                   ` Ben Collins
2013-03-22 16:16                     ` David Miller
2013-03-22 16:23                       ` Ben Collins
2013-03-22 22:08             ` Theodore Ts'o
2013-03-23 19:10               ` Guenter Roeck
2013-04-01 14:13               ` Mark Brown
2013-03-23 19:02         ` Guenter Roeck
2013-03-24 19:06           ` Guenter Roeck
2013-03-22 14:23 ` Eric Dumazet
2013-03-22 14:50   ` Ben Collins
2013-03-22 15:01     ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130322.101139.1942128058226201237.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=afleming@freescale.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.