All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Graf <tgraf@suug.ch>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: nicolas.dichtel@6wind.com, shemminger@vyatta.com, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2] libnetlink: check flag NLM_F_DUMP_INTR during dumps
Date: Fri, 22 Mar 2013 15:22:13 +0000	[thread overview]
Message-ID: <20130322152213.GB11368@casper.infradead.org> (raw)
In-Reply-To: <1363965296.4431.69.camel@edumazet-glaptop>

On 03/22/13 at 08:14am, Eric Dumazet wrote:
> On Fri, 2013-03-22 at 16:03 +0100, Nicolas Dichtel wrote:
> > Le 22/03/2013 15:59, Eric Dumazet a écrit :
> > > On Fri, 2013-03-22 at 15:45 +0100, Nicolas Dichtel wrote:
> > >> When this flag is set, it means that dump was interrupted and result may be
> > >> wrong. Ask user to restart.
> > >>
> > >> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> > >
> > >
> > > Do we have a guarantee this will complete eventually, on some hosts
> > > constantly adding removing entries ?
> > >
> > 
> > No. You mean it will be better to just print a warning and continue the dump?
> 
> I would not break the dump, return the indication, so that caller can
> chose to restart the loop one or two times.

Right, I would do it on an informal level at first. In fact libnl
will do an automatic restart of cache refills but I'm considering
to make it configurable for the application.

  reply	other threads:[~2013-03-22 15:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-22 14:45 [PATCH iproute2] libnetlink: check flag NLM_F_DUMP_INTR during dumps Nicolas Dichtel
2013-03-22 14:59 ` Eric Dumazet
2013-03-22 15:03   ` Nicolas Dichtel
2013-03-22 15:14     ` Eric Dumazet
2013-03-22 15:22       ` Thomas Graf [this message]
2013-03-22 15:42         ` [PATCH iproute2 v2] " Nicolas Dichtel
2013-03-22 15:49           ` Eric Dumazet
2013-03-22 16:34             ` [PATCH iproute2 v3] " Nicolas Dichtel
2013-03-24 21:17               ` [PATCH net-next v2 2/2] ipv6: provide addr and netconf dump consistency info David Miller
  -- strict thread matches above, loose matches on Subject: below --
2013-03-22 14:42 [PATCH net-next 1/2] ipv4: " Nicolas Dichtel
2013-03-22 14:42 ` [PATCH net-next 2/2] ipv6: " Nicolas Dichtel
2013-03-22 16:22   ` Nicolas Dichtel
2013-03-22 16:28     ` [PATCH net-next v2 1/2] ipv4: " Nicolas Dichtel
2013-03-22 16:28       ` [PATCH net-next v2 2/2] ipv6: " Nicolas Dichtel
2013-03-24 21:16       ` [PATCH net-next v2 1/2] ipv4: " David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130322152213.GB11368@casper.infradead.org \
    --to=tgraf@suug.ch \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.dichtel@6wind.com \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.