From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] bridge: avoid br_ifinfo_notify when nothing changed Date: Sun, 24 Mar 2013 17:18:07 -0400 (EDT) Message-ID: <20130324.171807.1183155678794281928.davem@davemloft.net> References: <1364015653-7322-1-git-send-email-honkiko@gmail.com> <1364131607-11698-1-git-send-email-honkiko@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: sergei.shtylyov@cogentembedded.com, netdev@vger.kernel.org, bridge@lists.linux-foundation.org, zhiguo.hong@emc.com, stephen@networkplumber.org, herbert@gondor.hengli.com.au To: honkiko@gmail.com Return-path: In-Reply-To: <1364131607-11698-1-git-send-email-honkiko@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bridge-bounces@lists.linux-foundation.org Errors-To: bridge-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org From: Hong Zhiguo Date: Sun, 24 Mar 2013 21:26:47 +0800 > When neither IFF_BRIDGE nor IFF_BRIDGE_PORT is set, > and afspec == NULL but protinfo != NULL, we run into > "if (err == 0) br_ifinfo_notify(RTM_NEWLINK, p);" with > random value in ret. > > Thanks to Sergei for pointing out the error in commit comments. > > Signed-off-by: Hong Zhiguo Applied. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sun, 24 Mar 2013 17:18:07 -0400 (EDT) Message-Id: <20130324.171807.1183155678794281928.davem@davemloft.net> From: David Miller In-Reply-To: <1364131607-11698-1-git-send-email-honkiko@gmail.com> References: <1364015653-7322-1-git-send-email-honkiko@gmail.com> <1364131607-11698-1-git-send-email-honkiko@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH net-next] bridge: avoid br_ifinfo_notify when nothing changed List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: honkiko@gmail.com Cc: sergei.shtylyov@cogentembedded.com, netdev@vger.kernel.org, bridge@lists.linux-foundation.org, zhiguo.hong@emc.com, stephen@networkplumber.org, herbert@gondor.hengli.com.au From: Hong Zhiguo Date: Sun, 24 Mar 2013 21:26:47 +0800 > When neither IFF_BRIDGE nor IFF_BRIDGE_PORT is set, > and afspec == NULL but protinfo != NULL, we run into > "if (err == 0) br_ifinfo_notify(RTM_NEWLINK, p);" with > random value in ret. > > Thanks to Sergei for pointing out the error in commit comments. > > Signed-off-by: Hong Zhiguo Applied.