All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: ncardwell@google.com
Cc: ycheng@google.com, edumazet@google.com, nanditad@google.com,
	netdev@vger.kernel.org
Subject: Re: [PATCH] tcp: undo spurious timeout after SACK reneging
Date: Sun, 24 Mar 2013 17:28:21 -0400 (EDT)	[thread overview]
Message-ID: <20130324.172821.1575298454791235977.davem@davemloft.net> (raw)
In-Reply-To: <CADVnQy=koYif1cM+VuXirz26jV33zDK2KHNW=EQUfRaGqBHa+g@mail.gmail.com>

From: Neal Cardwell <ncardwell@google.com>
Date: Sun, 24 Mar 2013 16:50:41 -0400

> On Sun, Mar 24, 2013 at 4:42 PM, Yuchung Cheng <ycheng@google.com> wrote:
>> On SACK reneging the sender immediately retransmits and forces a
>> timeout but disables Eifel (undo). If the (buggy) receiver does not
>> drop any packet this can trigger a false slow-start retransmit storm
>> driven by the ACKs of the original packets. This can be detected with
>> undo and TCP timestamps.
>>
>> Signed-off-by: Yuchung Cheng <ycheng@google.com>
>> ---
>>  net/ipv4/tcp_input.c | 7 ++-----
>>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> Acked-by: Neal Cardwell <ncardwell@google.com>

Applied.

      reply	other threads:[~2013-03-24 21:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-24 20:42 [PATCH] tcp: undo spurious timeout after SACK reneging Yuchung Cheng
2013-03-24 20:50 ` Neal Cardwell
2013-03-24 21:28   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130324.172821.1575298454791235977.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=nanditad@google.com \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=ycheng@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.