From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59702) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UK5yt-0003uX-FR for qemu-devel@nongnu.org; Mon, 25 Mar 2013 07:54:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UK5ys-0000nQ-4L for qemu-devel@nongnu.org; Mon, 25 Mar 2013 07:54:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52926) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UK5yr-0000nG-UJ for qemu-devel@nongnu.org; Mon, 25 Mar 2013 07:54:26 -0400 Date: Mon, 25 Mar 2013 11:54:22 +0000 From: "Richard W.M. Jones" Message-ID: <20130325115421.GA26045@rhmail.home.annexia.org> References: <1364209249-30630-1-git-send-email-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1364209249-30630-1-git-send-email-stefanha@redhat.com> Subject: Re: [Qemu-devel] [PULL 0/2] Block patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Anthony Liguori , qemu-devel@nongnu.org On Mon, Mar 25, 2013 at 12:00:47PM +0100, Stefan Hajnoczi wrote: > This tiny pull request contains build fixes for a regression introduced in the > last pull request. > > Kevin and I investigated to find out why these build failures were missed. > Both my buildslave and Kevin's workstation did not have the rbd libraries > installed so block/rbd.c was not built. > > The buildslave now has the missing libraries and will warn us if block/rbd.c > breaks again. Kevin has also installed the package so his local builds > exercise the code. > > The mingw build is already failing in buildbot due to an unrelated issue. The > bdrv_file_open() prototype warning was not spotted amongst all the other > warnings. > > The following changes since commit fe6344a05fba26e16863fefcb823242e579b0991: > > Remove device_tree.o from hw/moxie/Makefile.objs. (2013-03-24 11:30:04 +0100) > > are available in the git repository at: > > git://github.com/stefanha/qemu.git block > > for you to fetch changes up to ea804cadf867a0521b9069193db339d041a40689: > > block: Add options QDict to bdrv_file_open() prototypes (fix MinGW build) (2013-03-25 09:53:04 +0100) Tested, and this fixes the build failure of rbd for me. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top