From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cmd/gpt: Support gpt command for all devices.
Date: Tue, 26 Mar 2013 15:04:19 +0100 [thread overview]
Message-ID: <20130326140419.E1DCF20063E@gemini.denx.de> (raw)
In-Reply-To: <1364288746-2597-1-git-send-email-egbert.eich@gmail.com>
Dear egbert.eich at googlemail.com,
In message <1364288746-2597-1-git-send-email-egbert.eich@gmail.com> you wrote:
> From: Egbert Eich <eich@suse.com>
>
> The gpt command was only implemented for mmc devices. There is no reason
> why this command should not be generalized and be applied all other
> storage device classes.
> This change both simplifies the implementation and eliminates a
> build failure for systems that don't support mmcs.
>
> Signed-off-by: Egbert Eich <eich@suse.com>
> ---
> common/cmd_gpt.c | 43 ++++++++++++++++++-------------------------
> 1 files changed, 18 insertions(+), 25 deletions(-)
Please mark resubmits of new versions of patches as such; also, please
provide a change log so we can see what you actually changed. Please
see [1] for detailled instructions, and consider using patman to help
you doing this.
[1] http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions
Note that this patch is still not checkpatch-clean:
WARNING: line over 80 characters
#195: FILE: common/cmd_gpt.c:310:
+ printf("%s: %s dev %d NOT available\n", __func__, argv[2], dev);
Please fix!!
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
As a general rule, the freedom of any people can be judged by the
volume of their laughter.
next prev parent reply other threads:[~2013-03-26 14:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-26 9:05 [U-Boot] [PATCH] cmd/gpt: Support gpt command for all devices egbert.eich at googlemail.com
2013-03-26 14:04 ` Wolfgang Denk [this message]
2013-04-09 15:11 ` [U-Boot] [Patch v2] " Egbert Eich
2013-04-09 15:28 ` Tom Rini
2013-04-10 13:44 ` Piotr Wilczek
-- strict thread matches above, loose matches on Subject: below --
2013-03-26 8:01 [U-Boot] [PATCH] " egbert.eich at googlemail.com
2013-03-26 11:29 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130326140419.E1DCF20063E@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.