From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752937Ab3C0OXf (ORCPT ); Wed, 27 Mar 2013 10:23:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10377 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751375Ab3C0OXe (ORCPT ); Wed, 27 Mar 2013 10:23:34 -0400 Date: Wed, 27 Mar 2013 15:23:23 +0100 From: Jiri Olsa To: Stephane Eranian Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@elte.hu, ak@linux.intel.com, acme@redhat.com, namhyung.kim@lge.com Subject: Re: [PATCH v7 11/18] perf tools: add mem access sampling core support Message-ID: <20130327142323.GD1092@krava.brq.redhat.com> References: <1359040242-8269-1-git-send-email-eranian@google.com> <1359040242-8269-12-git-send-email-eranian@google.com> <20130327141425.GC1092@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130327141425.GC1092@krava.brq.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 27, 2013 at 03:14:25PM +0100, Jiri Olsa wrote: > On Thu, Jan 24, 2013 at 04:10:35PM +0100, Stephane Eranian wrote: > > SNIP > > > > > +static void ip__resolve_data(struct machine *self, struct thread *thread, > > + u8 m, > > + struct addr_map_symbol *ams, > > + u64 addr) > > +{ > > + struct addr_location al; > > + > > + memset(&al, 0, sizeof(al)); > > + > > + thread__find_addr_location(thread, self, m, MAP__VARIABLE, addr, &al, > > + NULL); > > + ams->addr = addr; > > + ams->al_addr = al.addr; > > + ams->sym = al.sym; > > + ams->map = al.map; > > +} > > + > > +struct mem_info *machine__resolve_mem(struct machine *self, > > + struct thread *thr, > > + struct perf_sample *sample, > > + u8 cpumode) > > +{ > > + struct mem_info *mi; > > + > > + mi = calloc(1, sizeof(struct mem_info)); > > + if (!mi) > > + return NULL; > > + > > + ip__resolve_ams(self, thr, &mi->iaddr, sample->ip); > > + ip__resolve_data(self, thr, cpumode, &mi->daddr, sample->addr); > > question, should this be the other way around? like: > > ip__resolve_ams(machine, thr, &mi->daddr, sample->addr); > ip__resolve_data(machine, thr, cpumode, &mi->iaddr, sample->ip); ugh, I missed the MAP__VARIABLE/MAP__FUNCTION difference there, thanks Arnaldo! ;-) still, no need to guess the cpumode for ip and guess it for data? jirka