From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Dr. Greg Wettstein" Subject: Re: [PATCH 1/1]: tools: Retry blktap2 tapdisk message on interrupt. Date: Thu, 28 Mar 2013 02:45:32 -0500 Message-ID: <201303280745.r2S7jWfX031234@wind.enjellic.com> References: Reply-To: xen@enjellic.com Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Ian Jackson "Re: [PATCH 1/1]: tools: Retry blktap2 tapdisk message on interrupt." (Mar 25, 12:40pm) List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: "jbeulich@suse.com" , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On Mar 25, 12:40pm, Ian Jackson wrote: } Subject: Re: [PATCH 1/1]: tools: Retry blktap2 tapdisk message on interrup > Dr. Greg Wettstein writes ("[PATCH 1/1]: tools: Retry blktap2 tapdisk message on interrupt."): > > Re-start blktap2 IPC select call on interrupt. > Thanks. I have applied this patch. But I think you should worry > that the fix may be incomplete. I see calls to read() as well, and > read() can also fail with EINTR. Yes the read/write calls on the socket are interruptible as well. The last patch was definitely 'scratch the itch', we have never seen a failure on the read or write call. I suspect catching the select call interrupt is shielding the read/write calls from any interrupts. Nonetheless a complete fix should address the read/write calls. A patch immediately follows. It went through our test harness without any issues but since we are not proving it against a known regression it bears running in other test environments to make sure i doesn't trip any unexpected behavior. > Ian. Have a good weekend. }-- End of excerpt from Ian Jackson As always, Dr. G.W. Wettstein, Ph.D. Enjellic Systems Development, LLC. 4206 N. 19th Ave. Specializing in information infra-structure Fargo, ND 58102 development. PH: 701-281-1686 FAX: 701-281-3949 EMAIL: greg@enjellic.com ------------------------------------------------------------------------------ "According to the philosopher Ly Tin Wheedle, chaos is found in greatest abundance wherever order is being sought. It always defeats order, because it is better organized." -- Terry Pratchett Interesting Times