From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:35605)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1ULAfa-0004DA-PA
	for qemu-devel@nongnu.org; Thu, 28 Mar 2013 07:06:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1ULAfX-0003CC-Ub
	for qemu-devel@nongnu.org; Thu, 28 Mar 2013 07:06:58 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49115)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1ULAfX-0003C7-N8
	for qemu-devel@nongnu.org; Thu, 28 Mar 2013 07:06:55 -0400
Date: Thu, 28 Mar 2013 12:06:48 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20130328110648.GB3077@dhcp-200-207.str.redhat.com>
References: <1363961953-13561-1-git-send-email-xiawenc@linux.vnet.ibm.com>
	<1363961953-13561-17-git-send-email-xiawenc@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1363961953-13561-17-git-send-email-xiawenc@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH V10 16/17] hmp: show ImageInfo in 'info
	block'
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: aliguori@us.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com

Am 22.03.2013 um 15:19 hat Wenchao Xia geschrieben:
>   Now human monitor can show image details include internal
> snapshot info for every block device.
> 
> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>

I don't think we should do that unconditionally. 'info block' should be
a short summary of all block devices in use by the VM and this would
make it way too long.

We could either introduce an 'info block -v' to display everything, or
only do it for a single BlockDriverState with something like
'info block <blockdev-name>'. I'm not sure how easy those would be to
implement, though.

Kevin