All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali.rohar@gmail.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Eric Piel <eric.piel@tremplin-utc.net>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org, Tony Lindgren <tony@atomide.com>
Subject: Re: Driver lis3lv02d_i2c not working on Nokia RX-51
Date: Thu, 28 Mar 2013 15:11:34 +0100	[thread overview]
Message-ID: <201303281511.35101@pali> (raw)
In-Reply-To: <20130326205319.GK14155@blackmetal.musicnaut.iki.fi>

[-- Attachment #1: Type: Text/Plain, Size: 2749 bytes --]

On Tuesday 26 March 2013 21:53:19 Aaro Koskinen wrote:
> Hi,
> 
> On Tue, Mar 26, 2013 at 04:02:39PM +0100, Pali Rohár wrote:
> > CCing Aaro and Tony. Look at this thread on:
> > https://lkml.org/lkml/2013/2/16/152
> > 
> > What do you think how to fix this problem? I do not know
> > about any HW regulator for n900 accelerometer and possible
> > solutions could be revert that commit or adding fake
> > regulator to board code...
> 
> I think the following should work:
> 
> ...
> 
> From: Aaro Koskinen <aaro.koskinen@iki.fi>
> Date: Tue, 26 Mar 2013 21:34:22 +0200
> Subject: [PATCH] OMAP: RX-51: add missing regulator supply
> definitions for lis3lv02d
> 
> Add missing regulator definitions for lis3lv02d accelerometer.
> Fixes the following probe issue:
> 
> [   57.737518] lis3lv02d_i2c 3-001d: Failed to get supply
> 'Vdd': -517 [   57.747100] i2c 3-001d: Driver lis3lv02d_i2c
> requests probe deferral
> 
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> ---
>  arch/arm/mach-omap2/board-rx51-peripherals.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c
> b/arch/arm/mach-omap2/board-rx51-peripherals.c index
> 3a077df..1a88467 100644
> --- a/arch/arm/mach-omap2/board-rx51-peripherals.c
> +++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
> @@ -547,12 +547,16 @@ static struct regulator_consumer_supply
> rx51_vio_supplies[] = { REGULATOR_SUPPLY("DVDD", "2-0019"),
>  	/* Si4713 IO supply */
>  	REGULATOR_SUPPLY("vio", "2-0063"),
> +	/* lis3lv02d */
> +	REGULATOR_SUPPLY("Vdd_IO", "3-001d"),
>  };
> 
>  static struct regulator_consumer_supply
> rx51_vaux1_consumers[] = { REGULATOR_SUPPLY("vdds_sdi",
> "omapdss"),
>  	/* Si4713 supply */
>  	REGULATOR_SUPPLY("vdd", "2-0063"),
> +	/* lis3lv02d */
> +	REGULATOR_SUPPLY("Vdd", "3-001d"),
>  };
> 
>  static struct regulator_init_data rx51_vaux1 = {

Hi, on #maemo IRC channel we have found some accelerometer 
regulators and I wrote this patch which is working fine with 3.8:

@@ -728,12 +730,16 @@ static struct regulator_consumer_supply 
rx51_vio_supplies[] = {
 	REGULATOR_SUPPLY("DVDD", "2-0019"),
 	/* Si4713 IO supply */
 	REGULATOR_SUPPLY("vio", "2-0063"),
+	/* lis3lv02d IO supply */
+	REGULATOR_SUPPLY("Vdd_IO", "3-001d"),
 };
 
 static struct regulator_consumer_supply rx51_vaux1_consumers[] = 
{
 	REGULATOR_SUPPLY("vdds_sdi", "omapdss"),
 	/* Si4713 supply */
 	REGULATOR_SUPPLY("vdd", "2-0063"),
+	/* lis3lv02d supply */
+	REGULATOR_SUPPLY("Vdd", "3-001d"),
 };
 
 static struct regulator_init_data rx51_vaux1 = {

Now I see that patch is same as Aaro's :-) so please include it.

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

      parent reply	other threads:[~2013-03-28 14:11 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-16 23:46 Driver lis3lv02d_i2c not working on Nokia RX-51 Pali Rohár
2013-02-17 16:25 ` Mark Brown
2013-02-17 16:40   ` Pali Rohár
2013-02-17 18:17     ` Mark Brown
2013-03-24 14:50       ` Pali Rohár
2013-03-24 21:21         ` Mark Brown
2013-03-24 21:27           ` Pali Rohár
2013-03-24 22:14             ` Mark Brown
2013-03-24 22:44               ` Pali Rohár
2013-03-24 23:04                 ` Mark Brown
2013-03-26 15:02                   ` Pali Rohár
2013-03-26 15:44                     ` Mark Brown
2013-03-26 16:08                       ` Linus Torvalds
2013-03-26 17:08                         ` Mark Brown
2013-03-26 20:53                     ` Aaro Koskinen
2013-03-26 21:19                       ` Mark Brown
2013-03-28 14:11                       ` Pali Rohár [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201303281511.35101@pali \
    --to=pali.rohar@gmail.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=akpm@linux-foundation.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=eric.piel@tremplin-utc.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony@atomide.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.