From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Sat, 30 Mar 2013 07:29:07 +0100 Subject: [U-Boot] [PATCH 04/11] usb-ehci: add Faraday USB 2.0 EHCI controller support In-Reply-To: <1364540788-13943-5-git-send-email-dantesu@gmail.com> References: <1364540788-13943-1-git-send-email-dantesu@gmail.com> <1364540788-13943-5-git-send-email-dantesu@gmail.com> Message-ID: <201303300729.08106.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Kuo-Jung Su, > From: Kuo-Jung Su > > This patch add supports to both Faraday FUSBH200 and FOTG210, > these controllers slightly differ from standard EHCI specification. > > Signed-off-by: Kuo-Jung Su You want to fix the magic values here, use readl()/writel() to operate registers, kill the BIT() macro and review comments in common files. Best regards, Marek Vasut