All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/7] usb: Update device class in usb device's descriptor
Date: Tue, 2 Apr 2013 12:09:54 +0200	[thread overview]
Message-ID: <201304021209.54624.marex@denx.de> (raw)
In-Reply-To: <CAFp+6iHK1vT6eCV1pjR3wD8CFk9CP6pEXvLdZsfbN3U5NsSzvQ@mail.gmail.com>

Dear Vivek Gautam,

> CC: Amarendra
> 
> On Thu, Mar 28, 2013 at 7:58 PM, Marek Vasut <marex@denx.de> wrote:
> > Dear Vivek Gautam,
> > 
> >> Fetch the device class into usb device's dwcriptors,
> >> so that the host controller's driver can use this info
> >> to differentiate between HUB and DEVICE.
> >> 
> >> Signed-off-by: Amar <amarendra.xt@samsung.com>
> > 
> > Is this a full name? Otherwise this patch is OK.
> > 
> >> ---
> >> 
> >>  common/usb.c |    5 +++++
> >>  1 files changed, 5 insertions(+), 0 deletions(-)
> >> 
> >> diff --git a/common/usb.c b/common/usb.c
> >> index 40c1547..39fcedd 100644
> >> --- a/common/usb.c
> >> +++ b/common/usb.c
> >> @@ -888,6 +888,11 @@ int usb_new_device(struct usb_device *dev)
> >> 
> >>       dev->descriptor.bMaxPacketSize0 = desc->bMaxPacketSize0;
> >> 
> >> +     /* Fetch the device class, driver can use this info
> >> +      * to differentiate between HUB and DEVICE.
> >> +      */
> >> +     dev->descriptor.bDeviceClass = desc->bDeviceClass;
> >> +

btw this really needs fixing, both the comment and the dangling newline.

> >>       /* find the port number we're at */
> >>       if (parent) {
> >>       
> >>               int j;
> > 
> > Best regards,
> > Marek Vasut

Best regards,
Marek Vasut

  reply	other threads:[~2013-04-02 10:09 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-27  9:28 [U-Boot] [PATCH 0/7] usb: ss: Some fixes and cleanup for USB super-speed support Vivek Gautam
2013-03-27  9:28 ` [U-Boot] [PATCH 1/7] USB: Some cleanup prior to USB 3.0 interface addition Vivek Gautam
2013-03-28 14:26   ` Marek Vasut
2013-04-02  5:54     ` Vivek Gautam
2013-04-02  5:56       ` Vivek Gautam
2013-04-02  6:26       ` Marek Vasut
2013-04-02  6:37         ` Vivek Gautam
2013-04-02  6:46           ` Marek Vasut
2013-04-02  6:58             ` Vivek Gautam
2013-03-27  9:28 ` [U-Boot] [PATCH 2/7] usb: hub: Conditionally power on usb's root-hub ports Vivek Gautam
2013-03-28 14:28   ` Marek Vasut
2013-04-02  9:36     ` Vivek Gautam
2013-04-02 10:09       ` Marek Vasut
2013-04-02 10:29         ` Vivek Gautam
2013-04-02 10:33           ` Marek Vasut
2013-03-27  9:28 ` [U-Boot] [PATCH 3/7] usb: Update device class in usb device's descriptor Vivek Gautam
2013-03-28 14:28   ` Marek Vasut
2013-04-02  9:32     ` Vivek Gautam
2013-04-02 10:09       ` Marek Vasut [this message]
2013-04-02 10:30         ` Vivek Gautam
2013-03-27  9:29 ` [U-Boot] [PATCH 4/7] usb: hub: Fix enumration timeout Vivek Gautam
2013-03-28  3:33   ` Vipin Kumar
2013-04-01 20:13   ` Tom Rini
2013-04-02  4:55     ` Vivek Gautam
2013-04-02  5:12       ` Marek Vasut
2013-04-02  5:34         ` Vivek Gautam
2013-04-02  5:36           ` Vivek Gautam
2013-04-02  6:43             ` Marek Vasut
2013-03-27  9:29 ` [U-Boot] [PATCH 5/7] usb: hub: Increase device enumeration timeout for broken drives Vivek Gautam
2013-03-28 14:32   ` Marek Vasut
2013-04-02  9:33     ` Vivek Gautam
2013-04-02 13:53     ` Vivek Gautam
2013-04-04  3:58       ` Marek Vasut
2013-04-04 10:57         ` Vivek Gautam
2013-04-14 17:17           ` Marek Vasut
2013-03-27  9:29 ` [U-Boot] [PATCH 6/7] USB: SS: Add support for Super Speed USB interface Vivek Gautam
2013-03-28 14:35   ` Marek Vasut
2013-04-02  9:52     ` Vivek Gautam
2013-03-27  9:29 ` [U-Boot] [PATCH 7/7] usb: eth: Fix for updated usb interface descriptor structure Vivek Gautam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201304021209.54624.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.