All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v11 1/2] Introduced btrfs file-system with btrload command
Date: Wed, 3 Apr 2013 12:50:41 -0400	[thread overview]
Message-ID: <20130403165041.GL7035@bill-the-cat> (raw)
In-Reply-To: <1364912259-15488-1-git-send-email-adnan.ali@codethink.co.uk>

On Tue, Apr 02, 2013 at 03:17:38PM +0100, Adnan Ali wrote:

> Introduces btrfs file-system to read file from
> volume/sub-volumes with btrload command. This
> implementation has read-only support.
> This btrfs implementation is based on syslinux btrfs
> code, commit 269ebc845ebc8b46ef4b0be7fa0005c7fdb95b8d.
> 
> v11:	 Mirro super block check.
> v10:     patch problem reworked.
> v5:      merged with master.
> v4:      btrls command added.
> 
> Signed-off-by: Adnan Ali <adnan.ali@codethink.co.uk>

With ELDK 5.3 toolchain, I see:
btrfs.c: In function 'insert_map':
btrfs.c:144:4: warning: implicit declaration of function 'malloc' [-Wimplicit-function-declaration]
btrfs.c: In function 'btrfs_read_super_block':
btrfs.c:281:5: warning: unused variable 'boots' [-Wunused-variable]
btrfs.c:279:6: warning: unused variable 'ret' [-Wunused-variable]
btrfs.c: In function 'btrfs_read_chunk_tree':
btrfs.c:507:4: warning: format '%d' expects argument of type 'int', but argument 2 has type 'uint64_t' [-Wformat]
btrfs.c:503:6: warning: unused variable 'status' [-Wunused-variable]
btrfs.c: In function 'btrfs_iget_by_inr':
btrfs.c:563:24: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
btrfs.c:583:26: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
btrfs.c:591:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
btrfs.c: In function 'btrfs_iget':
btrfs.c:607:26: warning: initialization from incompatible pointer type [enabled by default]
btrfs.c:621:22: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
btrfs.c: In function 'btrfs_readlink':
btrfs.c:628:34: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
btrfs.c:629:21: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
btrfs.c: In function 'btrfs_readdir':
btrfs.c:637:26: warning: initialization from incompatible pointer type [enabled by default]
btrfs.c: In function 'btrfs_next_extent':
btrfs.c:682:26: warning: initialization from incompatible pointer type [enabled by default]
btrfs.c:695:25: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
btrfs.c:720:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
btrfs.c: In function 'btrfs_getfssec':
btrfs.c:729:26: warning: initialization from incompatible pointer type [enabled by default]
btrfs.c:730:12: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
btrfs.c:741:8: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
btrfs.c:729:21: warning: unused variable 'fs' [-Wunused-variable]
btrfs.c: In function 'put_inode':
btrfs.c:844:4: warning: implicit declaration of function 'free' [-Wimplicit-function-declaration]
btrfs.c: In function 'alloc_inode':
btrfs.c:854:24: warning: initialization makes pointer from integer without a cast [enabled by default]
btrfs.c:857:13: warning: assignment from incompatible pointer type [enabled by default]
btrfs.c: In function 'btrfs_open_file':
btrfs.c:952:2: warning: implicit declaration of function 'searchdir' [-Wimplicit-function-declaration]
btrfs.c: In function 'searchdir':
btrfs.c:1029:14: warning: assignment makes pointer from integer without a cast [enabled by default]
btrfs.c:1058:17: warning: pointer targets in assignment differ in signedness [-Wpointer-sign]
btrfs.c: In function 'getfssec':
btrfs.c:1114:11: warning: unused variable 'handle' [-Wunused-variable]
btrfs.c: In function 'generic_getfssec':
btrfs.c:1132:26: warning: initialization from incompatible pointer type [enabled by default]
btrfs.c:1132:21: warning: unused variable 'fs' [-Wunused-variable]
fs.c:97:3: warning: initialization from incompatible pointer type [enabled by default]
fs.c:97:3: warning: (near initialization for 'fstypes[2].ls') [enabled by default]

And with ELDK 4.2:
btrfs.c: In function 'insert_map':
btrfs.c:144: warning: implicit declaration of function 'malloc'
btrfs.c: In function 'btrfs_read_super_block':
btrfs.c:281: warning: unused variable 'boots'
btrfs.c:279: warning: unused variable 'ret'
btrfs.c: In function 'btrfs_read_chunk_tree':
btrfs.c:507: warning: format '%d' expects type 'int', but argument 2 has type 'uint64_t'
btrfs.c:503: warning: unused variable 'status'
btrfs.c: In function 'btrfs_iget':
btrfs.c:607: warning: initialization from incompatible pointer type
btrfs.c: In function 'btrfs_readdir':
btrfs.c:637: warning: initialization from incompatible pointer type
btrfs.c: In function 'btrfs_next_extent':
btrfs.c:682: warning: initialization from incompatible pointer type
btrfs.c: In function 'btrfs_getfssec':
btrfs.c:729: warning: initialization from incompatible pointer type
btrfs.c:729: warning: unused variable 'fs'
btrfs.c: In function 'put_inode':
btrfs.c:844: warning: implicit declaration of function 'free'
btrfs.c: In function 'alloc_inode':
btrfs.c:854: warning: initialization makes pointer from integer without a cast
btrfs.c:857: warning: assignment from incompatible pointer type
btrfs.c: In function 'btrfs_open_file':
btrfs.c:952: warning: implicit declaration of function 'searchdir'
btrfs.c: In function 'searchdir':
btrfs.c:1029: warning: assignment makes pointer from integer without a cast
btrfs.c:1058: warning: pointer targets in assignment differ in signedness
btrfs.c: In function 'getfssec':
btrfs.c:1114: warning: unused variable 'handle'
btrfs.c: In function 'generic_getfssec':
btrfs.c:1132: warning: initialization from incompatible pointer type
btrfs.c:1132: warning: unused variable 'fs'
fs.c:97: warning: initialization from incompatible pointer type

Please fix.  I can test ELDK 4.2 if you fix the ELDK 5.3 warnings (which
also show up with other toolchains).

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130403/cb88c3e2/attachment.pgp>

  parent reply	other threads:[~2013-04-03 16:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-02 14:17 [U-Boot] [PATCH v11 1/2] Introduced btrfs file-system with btrload command Adnan Ali
2013-04-02 14:17 ` [U-Boot] [PATCH v11 2/2] Enable btrfs support in mx53loco config Adnan Ali
2013-04-02 15:19   ` Robert Nelson
2013-04-02 15:38     ` Adnan Ali
2013-04-02 15:52       ` Robert Nelson
2013-04-02 17:03         ` Tom Rini
2013-04-02 17:13           ` Adnan Ali
2013-04-03 15:25           ` Adnan Ali
2013-04-02 16:41       ` Otavio Salvador
2013-04-02 17:10         ` Adnan Ali
2013-04-02 16:34   ` Otavio Salvador
2013-04-03 16:50 ` Tom Rini [this message]
2013-04-03 17:30   ` [U-Boot] [PATCH v11 1/2] Introduced btrfs file-system with btrload command Adnan Ali
2013-04-03 18:04     ` Tom Rini
     [not found] <20130403201402.95C014618DA@ducie-dc1.codethink.co.uk>
2013-04-03 20:40 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130403165041.GL7035@bill-the-cat \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.