All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Lindner <lindner_marek@yahoo.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Antonio Quartulli <antonio@open-mesh.com>
Subject: Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: drop useless argument seqno in neighbor creation
Date: Wed, 3 Apr 2013 19:03:37 +0800	[thread overview]
Message-ID: <201304031903.38093.lindner_marek@yahoo.de> (raw)
In-Reply-To: <1364215787-17935-1-git-send-email-ordex@autistici.org>

On Monday, March 25, 2013 20:49:46 Antonio Quartulli wrote:
> From: Antonio Quartulli <antonio@open-mesh.com>
> 
> the sequence number is not stored in struct neigh_node,
> therefore there is no need to pass such value to the
> neigh_node creation procedure.
> 
> At the moment the value is only used by a debug message, but
> given the fact that the seqno is not related to the neighbor
> object, it is better to print it elsewhere.
> 
> Signed-off-by: Antonio Quartulli <antonio@open-mesh.com>
> ---
> 
> do we really want to pass the seqno over every function just to print it at
> the end? If this value is really important (debug? don't know) it should
> be printed in a proper place, e.g. in the function that triggered the
> creation and that possibly has the seqno for other purposes...
> Otherwise we would not be able to create a neigh_nod unless we have a seqno
> to pass.
> 
> Cheers,
> 
>  bat_iv_ogm.c | 11 ++++-------
>  originator.c |  5 ++---
>  originator.h |  2 +-
>  3 files changed, 7 insertions(+), 11 deletions(-)

Applied in revision 30b5722.

Thanks,
Marek

      parent reply	other threads:[~2013-04-03 11:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-25 12:49 [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: drop useless argument seqno in neighbor creation Antonio Quartulli
2013-03-25 12:49 ` [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: slightly improve neighbor creation debug message Antonio Quartulli
2013-03-25 12:54   ` [B.A.T.M.A.N.] [PATCHv2 " Antonio Quartulli
2013-04-03 11:05     ` Marek Lindner
2013-04-03 11:03 ` Marek Lindner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201304031903.38093.lindner_marek@yahoo.de \
    --to=lindner_marek@yahoo.de \
    --cc=antonio@open-mesh.com \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.