From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161307Ab3DEErf (ORCPT ); Fri, 5 Apr 2013 00:47:35 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:53423 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161057Ab3DEErd (ORCPT ); Fri, 5 Apr 2013 00:47:33 -0400 Date: Fri, 05 Apr 2013 00:47:31 -0400 (EDT) Message-Id: <20130405.004731.151872753500597206.davem@davemloft.net> To: ebiederm@xmission.com Cc: svenjoac@gmx.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, dingtianhong@huawei.com, edumazet@google.com, luto@amacapital.net, ksrot@redhat.com, netdev@vger.kernel.org, eric.dumazet@gmail.com Subject: Re: [PATCH 1/2] Revert "af_unix: dont send SCM_CREDENTIAL when dest socket is NULL" From: David Miller In-Reply-To: <87li8zhwkw.fsf_-_@xmission.com> References: <1365035424.13853.48.camel@edumazet-glaptop> <878v4zjei0.fsf@xmission.com> <87li8zhwkw.fsf_-_@xmission.com> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (shards.monkeyblade.net [0.0.0.0]); Thu, 04 Apr 2013 21:47:33 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: ebiederm@xmission.com (Eric W. Biederman) Date: Wed, 03 Apr 2013 19:13:35 -0700 > > This reverts commit 14134f6584212d585b310ce95428014b653dfaf6. > > The problem that the above patch was meant to address is that af_unix > messages are not being coallesced because we are sending unnecesarry > credentials. Not sending credentials in maybe_add_creds totally > breaks unconnected unix domain sockets that wish to send credentails > to other sockets. > > In practice this break some versions of udev because they receive a > message and the sending uid is bogus so they drop the message. > > Cc: stable@vger.kernel.org > Reported-by: Sven Joachim > Signed-off-by: "Eric W. Biederman" Applied.