Re: [PATCH V3 1/2] ARM: OMAP3+: use cpu0-cpufreq driver in device tree supported boot

From: Tony Lindgren <tony@atomide.com>
To: Nishanth Menon <nm@ti.com>
Cc: "Rajendra Nayak" <rnayak@ti.com>,
	"Kevin Hilman" <khilman@linaro.org>,
	linux-omap <linux-omap@vger.kernel.org>,
	"Rob Herring" <robherring2@gmail.com>,
	cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
	"Paul Walmsley" <paul@pwsan.com>,
	"Benoît Cousson" <b-cousson@ti.com>,
	"Jon Hunter" <jon-hunter@ti.com>, Keerthy <j-keerthy@ti.com>,
	"Santosh Shilimkar" <santosh.shilimkar@ti.com>,
	"Shawn Guo" <shawn.guo@linaro.org>
Subject: Re: [PATCH V3 1/2] ARM: OMAP3+: use cpu0-cpufreq driver in device tree supported boot
Date: Fri, 5 Apr 2013 15:17:55 -0700	[thread overview]
Message-ID: <20130405221755.GI10155@atomide.com> (raw)
In-Reply-To: <20130405221041.GA8648@kahuna>

* Nishanth Menon <nm@ti.com> [130405 15:15]:
> How does the following look?
> Option a) not have a dummy node if CPUFREQ_CPU0 is not configured:
> static inline void omap_init_cpufreq(void)
> {
> 	struct platform_device_info devinfo = { };
> 
> 	if (!of_have_populated_dt())
> 		devinfo.name = "omap-cpufreq";
> 	else if (IS_ENABLED(CONFIG_GENERIC_CPUFREQ_CPU0))
> 		devinfo.name = "cpufreq-cpu0"
> 	
> 	if (devinfo.name)
> 		platform_device_register_full(&devinfo);
> }
> 
> Option b) leave a dummy node registered
> static inline void omap_init_cpufreq(void)
> {
> 	struct platform_device_info devinfo = { };
> 
> 	if (!of_have_populated_dt())
> 		devinfo.name = "omap-cpufreq";
> 	else
> 		devinfo.name = "cpufreq-cpu0"
> 	
> 	platform_device_register_full(&devinfo);
> }
> 
> If there are no objections to (b), I dont mind it either.

To me option (b) looks better as it's if else :)

Tony