From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Date: Tue, 09 Apr 2013 12:55:09 +0000 Subject: Re: [PATCH 14/18] cpufreq: sh: move cpufreq driver to drivers/cpufreq Message-Id: <20130409125509.GH15412@verge.net.au> List-Id: References: <3167220d1e262ff22078993a5beec55e82dfd951.1365079581.git.viresh.kumar@linaro.org> In-Reply-To: <3167220d1e262ff22078993a5beec55e82dfd951.1365079581.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Viresh Kumar Cc: rjw@sisk.pl, robin.randhawa@arm.com, Steve.Bannister@arm.com, Liviu.Dudau@arm.com, charles.garcia-tobin@arm.com, arvind.chauhan@arm.com, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-kernel@lists.linaro.org, patches@linaro.org, Paul Mundt , linux-sh@vger.kernel.org On Thu, Apr 04, 2013 at 06:24:22PM +0530, Viresh Kumar wrote: > This patch moves cpufreq driver of SUPERH architecture to drivers/cpufreq. Why? I am missing the cover email where I assume the explanation lies. > > Cc: Paul Mundt > Cc: linux-sh@vger.kernel.org > Signed-off-by: Viresh Kumar > Acked-by: Paul Mundt > --- > arch/sh/Kconfig | 18 ------------------ > arch/sh/kernel/Makefile | 1 - > drivers/cpufreq/Kconfig | 18 ++++++++++++++++++ > drivers/cpufreq/Makefile | 1 + > .../kernel/cpufreq.c => drivers/cpufreq/sh-cpufreq.c | 2 -- > 5 files changed, 19 insertions(+), 21 deletions(-) > rename arch/sh/kernel/cpufreq.c => drivers/cpufreq/sh-cpufreq.c (99%) > > diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig > index 5e85963..06e3163 100644 > --- a/arch/sh/Kconfig > +++ b/arch/sh/Kconfig > @@ -624,25 +624,7 @@ config SH_CLK_CPG_LEGACY > endmenu > > menu "CPU Frequency scaling" > - > source "drivers/cpufreq/Kconfig" > - > -config SH_CPU_FREQ > - tristate "SuperH CPU Frequency driver" > - depends on CPU_FREQ > - select CPU_FREQ_TABLE > - help > - This adds the cpufreq driver for SuperH. Any CPU that supports > - clock rate rounding through the clock framework can use this > - driver. While it will make the kernel slightly larger, this is > - harmless for CPUs that don't support rate rounding. The driver > - will also generate a notice in the boot log before disabling > - itself if the CPU in question is not capable of rate rounding. > - > - For details, take a look at . > - > - If unsure, say N. > - > endmenu > > source "arch/sh/drivers/Kconfig" > diff --git a/arch/sh/kernel/Makefile b/arch/sh/kernel/Makefile > index f259b37..261c8bf 100644 > --- a/arch/sh/kernel/Makefile > +++ b/arch/sh/kernel/Makefile > @@ -31,7 +31,6 @@ obj-$(CONFIG_VSYSCALL) += vsyscall/ > obj-$(CONFIG_SMP) += smp.o > obj-$(CONFIG_SH_STANDARD_BIOS) += sh_bios.o > obj-$(CONFIG_KGDB) += kgdb.o > -obj-$(CONFIG_SH_CPU_FREQ) += cpufreq.o > obj-$(CONFIG_MODULES) += sh_ksyms_$(BITS).o module.o > obj-$(CONFIG_KEXEC) += machine_kexec.o relocate_kernel.o > obj-$(CONFIG_CRASH_DUMP) += crash_dump.o > diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig > index 5030df5..602d5db 100644 > --- a/drivers/cpufreq/Kconfig > +++ b/drivers/cpufreq/Kconfig > @@ -258,5 +258,23 @@ depends on PPC32 || PPC64 > source "drivers/cpufreq/Kconfig.powerpc" > endmenu > > +menu "SH CPU Frequency scaling" > +depends on SUPERH > +config SH_CPU_FREQ > + tristate "SuperH CPU Frequency driver" > + select CPU_FREQ_TABLE > + help > + This adds the cpufreq driver for SuperH. Any CPU that supports > + clock rate rounding through the clock framework can use this > + driver. While it will make the kernel slightly larger, this is > + harmless for CPUs that don't support rate rounding. The driver > + will also generate a notice in the boot log before disabling > + itself if the CPU in question is not capable of rate rounding. > + > + For details, take a look at . > + > + If unsure, say N. > +endmenu > + > endif > endmenu > diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile > index f6226d1..12607d9 100644 > --- a/drivers/cpufreq/Makefile > +++ b/drivers/cpufreq/Makefile > @@ -88,3 +88,4 @@ obj-$(CONFIG_CRIS_MACH_ARTPEC3) += cris-artpec3-cpufreq.o > obj-$(CONFIG_ETRAXFS) += cris-etraxfs-cpufreq.o > obj-$(CONFIG_IA64_ACPI_CPUFREQ) += ia64-acpi-cpufreq.o > obj-$(CONFIG_LOONGSON2_CPUFREQ) += loongson2_cpufreq.o > +obj-$(CONFIG_SH_CPU_FREQ) += sh-cpufreq.o > diff --git a/arch/sh/kernel/cpufreq.c b/drivers/cpufreq/sh-cpufreq.c > similarity index 99% > rename from arch/sh/kernel/cpufreq.c > rename to drivers/cpufreq/sh-cpufreq.c > index 88c8fee..73adb64 100644 > --- a/arch/sh/kernel/cpufreq.c > +++ b/drivers/cpufreq/sh-cpufreq.c > @@ -1,6 +1,4 @@ > /* > - * arch/sh/kernel/cpufreq.c > - * > * cpufreq driver for the SuperH processors. > * > * Copyright (C) 2002 - 2012 Paul Mundt > -- > 1.7.12.rc2.18.g61b472e > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935614Ab3DIMzQ (ORCPT ); Tue, 9 Apr 2013 08:55:16 -0400 Received: from kirsty.vergenet.net ([202.4.237.240]:36533 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759223Ab3DIMzO (ORCPT ); Tue, 9 Apr 2013 08:55:14 -0400 Date: Tue, 9 Apr 2013 21:55:09 +0900 From: Simon Horman To: Viresh Kumar Cc: rjw@sisk.pl, robin.randhawa@arm.com, Steve.Bannister@arm.com, Liviu.Dudau@arm.com, charles.garcia-tobin@arm.com, arvind.chauhan@arm.com, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-kernel@lists.linaro.org, patches@linaro.org, Paul Mundt , linux-sh@vger.kernel.org Subject: Re: [PATCH 14/18] cpufreq: sh: move cpufreq driver to drivers/cpufreq Message-ID: <20130409125509.GH15412@verge.net.au> References: <3167220d1e262ff22078993a5beec55e82dfd951.1365079581.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3167220d1e262ff22078993a5beec55e82dfd951.1365079581.git.viresh.kumar@linaro.org> Organisation: Horms Solutions Ltd. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 04, 2013 at 06:24:22PM +0530, Viresh Kumar wrote: > This patch moves cpufreq driver of SUPERH architecture to drivers/cpufreq. Why? I am missing the cover email where I assume the explanation lies. > > Cc: Paul Mundt > Cc: linux-sh@vger.kernel.org > Signed-off-by: Viresh Kumar > Acked-by: Paul Mundt > --- > arch/sh/Kconfig | 18 ------------------ > arch/sh/kernel/Makefile | 1 - > drivers/cpufreq/Kconfig | 18 ++++++++++++++++++ > drivers/cpufreq/Makefile | 1 + > .../kernel/cpufreq.c => drivers/cpufreq/sh-cpufreq.c | 2 -- > 5 files changed, 19 insertions(+), 21 deletions(-) > rename arch/sh/kernel/cpufreq.c => drivers/cpufreq/sh-cpufreq.c (99%) > > diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig > index 5e85963..06e3163 100644 > --- a/arch/sh/Kconfig > +++ b/arch/sh/Kconfig > @@ -624,25 +624,7 @@ config SH_CLK_CPG_LEGACY > endmenu > > menu "CPU Frequency scaling" > - > source "drivers/cpufreq/Kconfig" > - > -config SH_CPU_FREQ > - tristate "SuperH CPU Frequency driver" > - depends on CPU_FREQ > - select CPU_FREQ_TABLE > - help > - This adds the cpufreq driver for SuperH. Any CPU that supports > - clock rate rounding through the clock framework can use this > - driver. While it will make the kernel slightly larger, this is > - harmless for CPUs that don't support rate rounding. The driver > - will also generate a notice in the boot log before disabling > - itself if the CPU in question is not capable of rate rounding. > - > - For details, take a look at . > - > - If unsure, say N. > - > endmenu > > source "arch/sh/drivers/Kconfig" > diff --git a/arch/sh/kernel/Makefile b/arch/sh/kernel/Makefile > index f259b37..261c8bf 100644 > --- a/arch/sh/kernel/Makefile > +++ b/arch/sh/kernel/Makefile > @@ -31,7 +31,6 @@ obj-$(CONFIG_VSYSCALL) += vsyscall/ > obj-$(CONFIG_SMP) += smp.o > obj-$(CONFIG_SH_STANDARD_BIOS) += sh_bios.o > obj-$(CONFIG_KGDB) += kgdb.o > -obj-$(CONFIG_SH_CPU_FREQ) += cpufreq.o > obj-$(CONFIG_MODULES) += sh_ksyms_$(BITS).o module.o > obj-$(CONFIG_KEXEC) += machine_kexec.o relocate_kernel.o > obj-$(CONFIG_CRASH_DUMP) += crash_dump.o > diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig > index 5030df5..602d5db 100644 > --- a/drivers/cpufreq/Kconfig > +++ b/drivers/cpufreq/Kconfig > @@ -258,5 +258,23 @@ depends on PPC32 || PPC64 > source "drivers/cpufreq/Kconfig.powerpc" > endmenu > > +menu "SH CPU Frequency scaling" > +depends on SUPERH > +config SH_CPU_FREQ > + tristate "SuperH CPU Frequency driver" > + select CPU_FREQ_TABLE > + help > + This adds the cpufreq driver for SuperH. Any CPU that supports > + clock rate rounding through the clock framework can use this > + driver. While it will make the kernel slightly larger, this is > + harmless for CPUs that don't support rate rounding. The driver > + will also generate a notice in the boot log before disabling > + itself if the CPU in question is not capable of rate rounding. > + > + For details, take a look at . > + > + If unsure, say N. > +endmenu > + > endif > endmenu > diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile > index f6226d1..12607d9 100644 > --- a/drivers/cpufreq/Makefile > +++ b/drivers/cpufreq/Makefile > @@ -88,3 +88,4 @@ obj-$(CONFIG_CRIS_MACH_ARTPEC3) += cris-artpec3-cpufreq.o > obj-$(CONFIG_ETRAXFS) += cris-etraxfs-cpufreq.o > obj-$(CONFIG_IA64_ACPI_CPUFREQ) += ia64-acpi-cpufreq.o > obj-$(CONFIG_LOONGSON2_CPUFREQ) += loongson2_cpufreq.o > +obj-$(CONFIG_SH_CPU_FREQ) += sh-cpufreq.o > diff --git a/arch/sh/kernel/cpufreq.c b/drivers/cpufreq/sh-cpufreq.c > similarity index 99% > rename from arch/sh/kernel/cpufreq.c > rename to drivers/cpufreq/sh-cpufreq.c > index 88c8fee..73adb64 100644 > --- a/arch/sh/kernel/cpufreq.c > +++ b/drivers/cpufreq/sh-cpufreq.c > @@ -1,6 +1,4 @@ > /* > - * arch/sh/kernel/cpufreq.c > - * > * cpufreq driver for the SuperH processors. > * > * Copyright (C) 2002 - 2012 Paul Mundt > -- > 1.7.12.rc2.18.g61b472e > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >