From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60795) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPnFE-0005fz-6v for qemu-devel@nongnu.org; Wed, 10 Apr 2013 01:06:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPnFD-0003d8-6v for qemu-devel@nongnu.org; Wed, 10 Apr 2013 01:06:52 -0400 Received: from [222.73.24.84] (port=33790 helo=song.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPnFC-0003cs-SE for qemu-devel@nongnu.org; Wed, 10 Apr 2013 01:06:51 -0400 Date: Wed, 10 Apr 2013 13:06:07 +0800 From: Hu Tao Message-ID: <20130410050607.GI19067@localhost.localdomain> References: <1364545124-9781-1-git-send-email-hutao@cn.fujitsu.com> <20130329133310.GA9206@morn.localdomain> <51559BD8.5080502@redhat.com> <20130330132009.GA12564@morn.localdomain> <20130331143410.GC21968@redhat.com> <20130402002257.GB15818@morn.localdomain> <20130402090746.GZ3889@redhat.com> <20130410003716.GA30255@morn.localdomain> MIME-Version: 1.0 In-Reply-To: <20130410003716.GA30255@morn.localdomain> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Subject: Re: [Qemu-devel] [SeaBIOS] [PATCH v16] Add pvpanic device driver List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin O'Connor Cc: Peter Maydell , Gleb Natapov , "Michael S. Tsirkin" , Jan Kiszka , seabios@seabios.org, qemu-devel , Markus Armbruster , Blue Swirl , Orit Wasserman , Juan Quintela , Alexander Graf , Christian Borntraeger , Andrew Jones , Alex Williamson , Sasha Levin , Stefan Hajnoczi , Luiz Capitulino , KAMEZAWA Hiroyuki , Anthony Liguori , Marcelo Tosatti , Paolo Bonzini On Tue, Apr 09, 2013 at 08:37:16PM -0400, Kevin O'Connor wrote: > On Tue, Apr 02, 2013 at 12:07:46PM +0300, Gleb Natapov wrote: > > On Mon, Apr 01, 2013 at 08:22:57PM -0400, Kevin O'Connor wrote: > > > On Sun, Mar 31, 2013 at 05:34:10PM +0300, Gleb Natapov wrote: > > > > On Sat, Mar 30, 2013 at 09:20:09AM -0400, Kevin O'Connor wrote: > > > > The patch uses existing channel between qemu and seabios, one > > > > romfile_loadint() is all it takes. We already have number of interfaces > > > > to change OS visible ACPI tables, that's why we want to move ACPI table > > > > creation to QEMU in the first place. It is unfortunate to start blocking > > > > features now before we have an alternative. When ACPI table creation > > > > will move into QEMU the code in this patch will be dropped along with > > > > all the other code that serves similar purpose. > > > > > > If there is a general consensus that this feature is important then > > > we'll go forward with adding it as is. To be clear though, my > > > preference would be to go forward with moving ACPI tables into QEMU, > > > and then add this stuff on top of that. If no one beats me to it, > > > I'll send some initial patches myself. > > > > > If we can accomplish the move before next major QEMU release we do not > > need this new fw_cfg file obviously. Paolo thinks this is not feasible, > > I haven't followed this work to close to have informed opinion. > > I was hoping I'd get a chance to submit some QEMU patches for this > before the soft-freeze, but unfortunately I have not been able to. > Since I don't want to hold up features, I remove my earlier objection > and I'm okay with committing this to SeaBIOS. Glad to hear that! > > Hu Tao - if the QEMU part of the pvpanic series is committed to QEMU > I'll commit the corresponding SeaBIOS parts. Thanks a lot! -- Regards, Hu Tao