From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mackerras Subject: Re: [PATCH v4 6/6] kvm/ppc/mpic: add KVM_CAP_IRQ_MPIC Date: Tue, 16 Apr 2013 13:59:51 +1000 Message-ID: <20130416035951.GA27197@iris.ozlabs.ibm.com> References: <1364954273-18196-1-git-send-email-scottwood@freescale.com> <1365811727-24431-1-git-send-email-scottwood@freescale.com> <1365811727-24431-7-git-send-email-scottwood@freescale.com> <20130415052328.GC7494@iris.ozlabs.ibm.com> <1366048347.15365.1@snotra> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Alexander Graf , kvm-ppc@vger.kernel.org, kvm@vger.kernel.org To: Scott Wood Return-path: Content-Disposition: inline In-Reply-To: <1366048347.15365.1@snotra> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Mon, Apr 15, 2013 at 12:52:27PM -0500, Scott Wood wrote: > On 04/15/2013 12:23:28 AM, Paul Mackerras wrote: > >On Fri, Apr 12, 2013 at 07:08:47PM -0500, Scott Wood wrote: > >> Enabling this capability connects the vcpu to the designated > >in-kernel > >> MPIC. Using explicit connections between vcpus and irqchips allows > >> for flexibility, but the main benefit at the moment is that it > >> simplifies the code -- KVM doesn't need vm-global state to remember > >> which MPIC object is associated with this vm, and it doesn't need to > >> care about ordering between irqchip creation and vcpu creation. > > > >This fails to link with CONFIG_KVM_MPIC=n with the following error: > > > >arch/powerpc/kvm/built-in.o: In function `.kvm_arch_vcpu_free': > >(.text+0x94f0): undefined reference to `.kvmppc_mpic_disconnect_vcpu' > > Sigh, forgot the ifdef again. :-( Or you could define an empty static inline function in the CONFIG_KVM_MPIC=n case, which looks a little nicer at the point of use. Paul. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mackerras Date: Tue, 16 Apr 2013 03:59:51 +0000 Subject: Re: [PATCH v4 6/6] kvm/ppc/mpic: add KVM_CAP_IRQ_MPIC Message-Id: <20130416035951.GA27197@iris.ozlabs.ibm.com> List-Id: References: <1364954273-18196-1-git-send-email-scottwood@freescale.com> <1365811727-24431-1-git-send-email-scottwood@freescale.com> <1365811727-24431-7-git-send-email-scottwood@freescale.com> <20130415052328.GC7494@iris.ozlabs.ibm.com> <1366048347.15365.1@snotra> In-Reply-To: <1366048347.15365.1@snotra> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Scott Wood Cc: Alexander Graf , kvm-ppc@vger.kernel.org, kvm@vger.kernel.org On Mon, Apr 15, 2013 at 12:52:27PM -0500, Scott Wood wrote: > On 04/15/2013 12:23:28 AM, Paul Mackerras wrote: > >On Fri, Apr 12, 2013 at 07:08:47PM -0500, Scott Wood wrote: > >> Enabling this capability connects the vcpu to the designated > >in-kernel > >> MPIC. Using explicit connections between vcpus and irqchips allows > >> for flexibility, but the main benefit at the moment is that it > >> simplifies the code -- KVM doesn't need vm-global state to remember > >> which MPIC object is associated with this vm, and it doesn't need to > >> care about ordering between irqchip creation and vcpu creation. > > > >This fails to link with CONFIG_KVM_MPIC=n with the following error: > > > >arch/powerpc/kvm/built-in.o: In function `.kvm_arch_vcpu_free': > >(.text+0x94f0): undefined reference to `.kvmppc_mpic_disconnect_vcpu' > > Sigh, forgot the ifdef again. :-( Or you could define an empty static inline function in the CONFIG_KVM_MPIC=n case, which looks a little nicer at the point of use. Paul.