Re: [PATCH v9] irq: add quirk for broken interrupt remapping on 55XX chipsets

From: Joerg Roedel <joro@8bytes.org>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: linux-kernel@vger.kernel.org,
	"Prarit Bhargava" <prarit@redhat.com>,
	"Don Zickus" <dzickus@redhat.com>,
	"Don Dutile" <ddutile@redhat.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Asit Mallick" <asit.k.mallick@intel.com>,
	"David Woodhouse" <dwmw2@infradead.org>,
	linux-pci@vger.kernel.org,
	"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
	"Arkadiusz Miśkiewicz" <arekm@maven.pl>
Subject: Re: [PATCH v9] irq: add quirk for broken interrupt remapping on 55XX chipsets
Date: Tue, 16 Apr 2013 12:24:54 +0200	[thread overview]
Message-ID: <20130416102454.GS6858@8bytes.org> (raw)
In-Reply-To: <1366065677-3431-1-git-send-email-nhorman@tuxdriver.com>

On Mon, Apr 15, 2013 at 06:41:17PM -0400, Neil Horman wrote:
> +#ifdef CONFIG_IRQ_REMAP
> +static void __init intel_remapping_check(int num, int slot, int func)
> +{
> +	u8 revision;
> +
> +	revision = read_pci_config_byte(num, slot, func, PCI_REVISION_ID);
> +
> +	/*
> +	 * Revision 0x13 of this chipset supports irq remapping
> +	 * but has an erratum that breaks its behavior, flag it as such
> +	 */
> +	if (revision == 0x13)
> +		irq_remap_broken = 1;
> +
> +}
> +#else

Any reason why you don't check this in the Intel IOMMU init code? You
would safe the ifdefs and you don't have to include
irq-remapping-internal header files somewhere else in the tree.

	Joerg