From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Thu, 18 Apr 2013 12:54:29 +0200 Subject: [U-Boot] [PATCH v2 04/12] i2c: add Faraday FTI2C010 I2C controller support In-Reply-To: <1366277139-29728-5-git-send-email-dantesu@gmail.com> References: <1366277139-29728-1-git-send-email-dantesu@gmail.com> <1364540788-13943-2-git-send-email-dantesu@gmail.com> <1366277139-29728-5-git-send-email-dantesu@gmail.com> Message-ID: <20130418105429.D4AA420019A@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Kuo-Jung Su, In message <1366277139-29728-5-git-send-email-dantesu@gmail.com> you wrote: ... > +#define I2C_READ(r) le32_to_cpu(readl(r)) > +#define I2C_WRITE(v, r) writel(cpu_to_le32(v), r) Please drop these macros and use the real functions instead. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Little known fact about Middle Earth: The Hobbits had a very sophi- sticated computer network! It was a Tolkien Ring...