All of lore.kernel.org
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@redhat.com>
To: Steve Dickson <SteveD@redhat.com>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>,
	"David P. Quigley" <dpquigl@tycho.nsa.gov>,
	Linux NFS list <linux-nfs@vger.kernel.org>,
	Linux FS devel list <linux-fsdevel@vger.kernel.org>,
	Linux Security List <linux-security-module@vger.kernel.org>,
	SELinux List <selinux@tycho.nsa.gov>
Subject: Re: [PATCH 00/19] lnfs: 3.9-rc5 release
Date: Tue, 23 Apr 2013 13:22:28 -0400	[thread overview]
Message-ID: <20130423172227.GF20622@pad.fieldses.org> (raw)
In-Reply-To: <20130423160520.GE20622@pad.fieldses.org>

On Tue, Apr 23, 2013 at 12:05:20PM -0400, J. Bruce Fields wrote:
> On Tue, Apr 23, 2013 at 11:46:45AM -0400, Steve Dickson wrote:
> > 
> > 
> > On 10/04/13 11:09, J. Bruce Fields wrote:
> > > On Tue, Apr 02, 2013 at 05:45:41PM -0400, Steve Dickson wrote:
> > >> > From: Steve Dickson <steved@redhat.com>
> > >> > 
> > >> > Here is the next release of the Label NFS patches 
> > >> > forward ported to linux-3.9-rc3.
> > >> > 
> > >> > I decided to include the the v4.2 enabling patches since 
> > >> > I'm doing all my testing with both sets so at this point 
> > >> > I don't think it makes sense to separate them. Plus I'm
> > >> > hoping they will take care of the SETATTR problem Bruce was 
> > >> > seeing since label attributes were leaking into the bitmask
> > >> > when they were not suppose to. 
> > > Still getting a failure.  All you need to do is something like:
> > > 
> > > 	git clone git://linux-nfs.org/~bfields/pynfs.git
> > > 	cd pynfs
> > > 	./setup.py build
> > > 	./setup.py build_ext --inplace
> > > 	./nfs4.0/testserver.py pip1:/path/to/export/tmpdir ---maketree --rundeps SATT13
> > Unfortunately, I'm not able to reproduce this error on any of the following kernels
> > * No labels 
> > * No labels configured
> >     # CONFIG_NFS_V4_2 is not set
> >     # CONFIG_NFSD_V4_SECURITY_LABEL is not set
> > * Labels configured 
> >    CONFIG_NFS_V4_2=y
> >    CONFIG_NFS_V4_SECURITY_LABEL=y
> > 
> > What exactly was failing?
> 
> Sorry I can't find the results right now.  I'll re-run and let you know.

The server is returning -EOPNOTSUPP in response to an nfs4 SETATTR which
sets a mode.

The operation shouldn't be failing, and if it does it should return an
NFS error, not -ERRNO.

I can't reproduce this just by doing chmod on the linux client.  I'm not
sure what pynfs is doing differently to trigger the bug.

--b.

  reply	other threads:[~2013-04-23 17:22 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-02 21:45 [PATCH 00/19] lnfs: 3.9-rc5 release Steve Dickson
2013-04-02 21:45 ` Steve Dickson
2013-04-02 21:45 ` [PATCH 01/19] Security: Add hook to calculate context based on a negative dentry Steve Dickson
2013-04-02 23:35   ` Myklebust, Trond
     [not found]     ` <1364945729.3026.7.camel-5lNtUQgoD8Pfa3cDbr2K10B+6BGkLq7r@public.gmane.org>
2013-04-03 19:57       ` David Quigley
2013-04-03 19:57         ` David Quigley
2013-04-03 19:57         ` David Quigley
2013-04-02 21:45 ` [PATCH 03/19] LSM: Add flags field to security_sb_set_mnt_opts for in kernel mount data Steve Dickson
2013-04-02 21:45 ` [PATCH 04/19] SELinux: Add new labeling type native labels Steve Dickson
2013-04-02 21:45 ` [PATCH 05/19] NFSv4: Add label recommended attribute and NFSv4 flags Steve Dickson
2013-04-02 21:45 ` [PATCH 06/19] NFSv4: Introduce new label structure Steve Dickson
2013-04-02 21:45 ` [PATCH 07/19] NFSv4: Extend fattr bitmaps to support all 3 words Steve Dickson
2013-04-02 21:45 ` [PATCH 09/19] NFS: Add label lifecycle management Steve Dickson
2013-04-02 21:45 ` [PATCH 10/19] NFS: Client implementation of Labeled-NFS Steve Dickson
2013-04-02 21:45 ` [PATCH 11/19] NFS: Extend NFS xattr handlers to accept the security namespace Steve Dickson
2013-04-02 21:45 ` [PATCH 14/19] Kconfig: Add Kconfig entry for Labeled NFS V4 server Steve Dickson
2013-04-02 21:45 ` [PATCH 15/19] NFSv4.2: Added NFS v4.2 support to the NFS client Steve Dickson
2013-04-02 21:45 ` [PATCH 16/19] NFSv4.2: Only allocate labels on v4.2 mounts Steve Dickson
2013-04-02 21:45 ` [PATCH 17/19] NFSv4.2: Only set the label attribute " Steve Dickson
2013-04-02 21:45 ` [PATCH 18/19] NFSv4.2: Added v4.2 error codes Steve Dickson
     [not found] ` <1364939160-20874-1-git-send-email-SteveD-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-04-02 21:45   ` [PATCH 02/19] Security: Add Hook to test if the particular xattr is part of a MAC model Steve Dickson
2013-04-02 21:45     ` Steve Dickson
2013-04-02 21:45   ` [PATCH 08/19] NFS:Add labels to client function prototypes Steve Dickson
2013-04-02 21:45     ` Steve Dickson
2013-04-02 21:45   ` [PATCH 12/19] Kconfig: Add Kconfig entry for Labeled NFS V4 client Steve Dickson
2013-04-02 21:45     ` Steve Dickson
2013-04-02 21:45   ` [PATCH 13/19] NFSD: Server implementation of MAC Labeling Steve Dickson
2013-04-02 21:45     ` Steve Dickson
     [not found]     ` <1364939160-20874-14-git-send-email-SteveD-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2013-04-10 15:19       ` J. Bruce Fields
2013-04-10 15:19         ` J. Bruce Fields
     [not found]         ` <20130410151953.GC24404-spRCxval1Z7TsXDwO4sDpg@public.gmane.org>
2013-04-23 19:40           ` Steve Dickson
2013-04-23 19:40             ` Steve Dickson
2013-04-23 19:44             ` J. Bruce Fields
2013-04-23 19:51               ` Steve Dickson
2013-04-02 21:46   ` [PATCH 19/19] NFSDv4.2: Added NFS v4.2 support to the NFS server Steve Dickson
2013-04-02 21:46     ` Steve Dickson
2013-04-10 15:25     ` J. Bruce Fields
2013-04-10 15:58       ` Steve Dickson
2013-04-10 20:12         ` J. Bruce Fields
2013-04-11 16:58           ` Steve Dickson
2013-04-10 15:09 ` [PATCH 00/19] lnfs: 3.9-rc5 release J. Bruce Fields
     [not found]   ` <20130410150940.GB24404-spRCxval1Z7TsXDwO4sDpg@public.gmane.org>
2013-04-10 15:48     ` Steve Dickson
2013-04-10 15:48       ` Steve Dickson
2013-04-12 15:03       ` J. Bruce Fields
2013-04-23 15:46     ` Steve Dickson
2013-04-23 15:46       ` Steve Dickson
2013-04-23 16:05       ` J. Bruce Fields
2013-04-23 17:22         ` J. Bruce Fields [this message]
     [not found]           ` <20130423172227.GF20622-spRCxval1Z7TsXDwO4sDpg@public.gmane.org>
2013-04-23 18:04             ` Steve Dickson
2013-04-23 18:04               ` Steve Dickson
     [not found]               ` <5176CD42.4080405-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2013-04-23 18:15                 ` J. Bruce Fields
2013-04-23 18:15                   ` J. Bruce Fields
2013-04-23 18:40               ` Mimi Zohar
2013-04-23 18:40                 ` Mimi Zohar
2013-04-23 18:57                 ` Steve Dickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130423172227.GF20622@pad.fieldses.org \
    --to=bfields@redhat.com \
    --cc=SteveD@redhat.com \
    --cc=Trond.Myklebust@netapp.com \
    --cc=dpquigl@tycho.nsa.gov \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.