From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH v2 00/11] vhost cleanups Date: Mon, 6 May 2013 16:15:35 +0300 Message-ID: <20130506131535.GA14821@redhat.com> References: <1367829509-5371-1-git-send-email-asias@redhat.com> <20130506100746.GA16938@redhat.com> <20130506120526.GA7701@hj.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: target-devel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org To: Asias He Return-path: Content-Disposition: inline In-Reply-To: <20130506120526.GA7701@hj.localdomain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org List-Id: kvm.vger.kernel.org On Mon, May 06, 2013 at 08:05:26PM +0800, Asias He wrote: > On Mon, May 06, 2013 at 01:07:46PM +0300, Michael S. Tsirkin wrote: > > On Mon, May 06, 2013 at 04:38:18PM +0800, Asias He wrote: > > > MST, This is on top of [PATCH 0/2] vhost-net fix ubuf. > > > > Okay, how about making EVENT_IDX work for virtio-scsi? > > I'm guessing it's some messup with feature negotiation, > > that's what all event-idx bugs came down to so far. > > Yes, IIRC, EVENT_IDX works for vhost-scsi now. Will cook a patch to > enable it. It should go 3.10, right? If it's early in the cycle, I think it can. > > > Asias He (11): > > > vhost: Remove vhost_enable_zcopy in vhost.h > > > vhost: Move VHOST_NET_FEATURES to net.c > > > vhost: Make vhost a separate module > > > vhost: Remove comments for hdr in vhost.h > > > vhost: Simplify dev->vqs[i] access > > > vhost-net: Cleanup vhost_ubuf and vhost_zcopy > > > vhost-scsi: Remove unnecessary forward struct vhost_scsi declaration > > > vhost-scsi: Rename struct vhost_scsi *s to *vs > > > vhost-scsi: Make func indention more consistent > > > vhost-scsi: Rename struct tcm_vhost_tpg *tv_tpg to *tpg > > > vhost-scsi: Rename struct tcm_vhost_cmd *tv_cmd to *cmd > > > > > > drivers/vhost/Kconfig | 8 + > > > drivers/vhost/Makefile | 3 +- > > > drivers/vhost/net.c | 64 ++++--- > > > drivers/vhost/scsi.c | 470 ++++++++++++++++++++++++++----------------------- > > > drivers/vhost/vhost.c | 86 +++++++-- > > > drivers/vhost/vhost.h | 11 +- > > > 6 files changed, 361 insertions(+), 281 deletions(-) > > > > > > -- > > > 1.8.1.4 > > -- > Asias