From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson Subject: Re: [PATCH 5/6] KVM: PPC: Add support for IOMMU in-kernel handling Date: Tue, 7 May 2013 16:54:07 +1000 Message-ID: <20130507065407.GT13692@truffula.fritz.box> References: <1367825157-27231-1-git-send-email-aik@ozlabs.ru> <1367825157-27231-6-git-send-email-aik@ozlabs.ru> <20130507052933.GP13692@truffula.fritz.box> <51889663.5060909@ozlabs.ru> <20130507060240.GQ13692@truffula.fritz.box> <51889EE5.5050807@ozlabs.ru> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="nNx5P6V1TPcCvZS+" Cc: kvm@vger.kernel.org, Joerg Roedel , Alexander Graf , kvm-ppc@vger.kernel.org, Alex Williamson , Paul Mackerras , linuxppc-dev@lists.ozlabs.org To: Alexey Kardashevskiy Return-path: Content-Disposition: inline In-Reply-To: <51889EE5.5050807@ozlabs.ru> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org --nNx5P6V1TPcCvZS+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 07, 2013 at 04:27:49PM +1000, Alexey Kardashevskiy wrote: > On 05/07/2013 04:02 PM, David Gibson wrote: > > On Tue, May 07, 2013 at 03:51:31PM +1000, Alexey Kardashevskiy wrote: > >> On 05/07/2013 03:29 PM, David Gibson wrote: > >>> On Mon, May 06, 2013 at 05:25:56PM +1000, Alexey Kardashevskiy wrote: [snip] > >>>> +#define DRIVER_VERSION "0.1" > >>>> +#define DRIVER_AUTHOR "Paul Mackerras, IBM Corp. " > >>>> +#define DRIVER_DESC "POWERPC KVM driver" > >>> > >>> Really? > >> > >> > >> What is wrong here? > >=20 > > Well, it seems entirely unrelated to the rest of the changes,=20 >=20 >=20 > The patch adds a module parameter so I had to add those DRIVER_xxx. Ah, ok. > > and not obviously accurate. >=20 > Let's fix it then. How? Paul signed it... Fair enough then. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --nNx5P6V1TPcCvZS+ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlGIpQ8ACgkQaILKxv3ab8bw8wCeJIzUXP39MoqIIYNCRSM2lFms MrwAnRUZcsWIXk+2a5fFzU8vr0zpCi6v =x9Bz -----END PGP SIGNATURE----- --nNx5P6V1TPcCvZS+-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson Date: Tue, 07 May 2013 06:54:07 +0000 Subject: Re: [PATCH 5/6] KVM: PPC: Add support for IOMMU in-kernel handling Message-Id: <20130507065407.GT13692@truffula.fritz.box> MIME-Version: 1 Content-Type: multipart/mixed; boundary="nNx5P6V1TPcCvZS+" List-Id: References: <1367825157-27231-1-git-send-email-aik@ozlabs.ru> <1367825157-27231-6-git-send-email-aik@ozlabs.ru> <20130507052933.GP13692@truffula.fritz.box> <51889663.5060909@ozlabs.ru> <20130507060240.GQ13692@truffula.fritz.box> <51889EE5.5050807@ozlabs.ru> In-Reply-To: <51889EE5.5050807@ozlabs.ru> To: Alexey Kardashevskiy Cc: kvm@vger.kernel.org, Joerg Roedel , Alexander Graf , kvm-ppc@vger.kernel.org, Alex Williamson , Paul Mackerras , linuxppc-dev@lists.ozlabs.org --nNx5P6V1TPcCvZS+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 07, 2013 at 04:27:49PM +1000, Alexey Kardashevskiy wrote: > On 05/07/2013 04:02 PM, David Gibson wrote: > > On Tue, May 07, 2013 at 03:51:31PM +1000, Alexey Kardashevskiy wrote: > >> On 05/07/2013 03:29 PM, David Gibson wrote: > >>> On Mon, May 06, 2013 at 05:25:56PM +1000, Alexey Kardashevskiy wrote: [snip] > >>>> +#define DRIVER_VERSION "0.1" > >>>> +#define DRIVER_AUTHOR "Paul Mackerras, IBM Corp. " > >>>> +#define DRIVER_DESC "POWERPC KVM driver" > >>> > >>> Really? > >> > >> > >> What is wrong here? > >=20 > > Well, it seems entirely unrelated to the rest of the changes,=20 >=20 >=20 > The patch adds a module parameter so I had to add those DRIVER_xxx. Ah, ok. > > and not obviously accurate. >=20 > Let's fix it then. How? Paul signed it... Fair enough then. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --nNx5P6V1TPcCvZS+ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlGIpQ8ACgkQaILKxv3ab8bw8wCeJIzUXP39MoqIIYNCRSM2lFms MrwAnRUZcsWIXk+2a5fFzU8vr0zpCi6v =x9Bz -----END PGP SIGNATURE----- --nNx5P6V1TPcCvZS+--